Grab po files for the docs. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But in order to successfully run the command, one will need to `pip install` the dependencies for the sphinx-docs/requirements.txt file.
| os.chdir(os.path.join("ka-lite-submodule", "sphinx-docs")) | ||
| p = Popen(["make", "gettext"]) | ||
| p.wait() | ||
| p = Popen(["sphinx-intl", "update", "-p", "_build/locale", "-l", "en"]) |
There was a problem hiding this comment.
The central server uses python2.7, so it's preferred to use subprocess.call in here.
|
Aside from one comment, changes look good. |
|
Submodule should be updated to include changes from this PR, then this can be merged. |
|
Merge conflicts? :( |
|
Rebase! |
| @@ -36,7 +36,7 @@ | |||
| CROWDIN_API_URL = "https://api.crowdin.com/api/project" | |||
|
|
|||
|
|
|||
| class Command(test_wrappings.Command): | |||
| class Command(BaseCommand): | |||
There was a problem hiding this comment.
This thing has been fixed in 3 branches so far. Ha!
aronasorman
added a commit
that referenced
this pull request
Apr 8, 2015
Grab po files for the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's inside:
import_all_child_modulesvestiges.update_potcommand to grab messages from the docs, in addition to the app.The submodule needs to incorporate changes from this branch in order for this to work, and furthermore before you run this command you need to first grab the dependencies from
sphinx-docs/requirements.txtin the submodule.