Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): generate some basic test scripts #274

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Oct 8, 2024

resolves #272

  • generate test scripts button in Post Script section
  • add rf.response.getResponseTime()
  • known issue is still existing: updatePlugin doesn't show updated test scripts until you refresh the page

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 16cabe3
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/670543a5c257e20007fbb11f
😎 Deploy Preview https://deploy-preview-274--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

flawiddsouza commented Oct 8, 2024

issue: updatePlugin doesn't show updated test scripts until you refresh the page

are you saying this is fixed or the issue is there?

@kobenguyent
Copy link
Collaborator Author

issue: updatePlugin doesn't show updated test scripts until you refresh the page

are you saying this is fixed or the issue is there?

issue is still there, your brain on it would be appreciated.

@flawiddsouza
Copy link
Owner

image
This should be a const. No need for it to be a data property, as it is used only within the scope.

@flawiddsouza
Copy link
Owner

Isn't it better if we add a button here instead of the context menu?
image
Context menu has been getting overloaded with items.

@kobenguyent
Copy link
Collaborator Author

Isn't it better if we add a button here instead of the context menu? image Context menu has been getting overloaded with items.

that's actually a good idea.

@flawiddsouza
Copy link
Owner

Remove leftover code / code that's no longer in use:
image

Block scoped variable doesn't need to be reset
image
image
Make it a const as the value doesn't change within scope

While updating any object in the database, pass only values that need to change. Not the full object. Makes it clear what exactly you want to save. Other values are already the same.
image

@flawiddsouza flawiddsouza merged commit 0c2eac8 into main Oct 8, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-generate-tests branch October 8, 2024 15:29
@flawiddsouza
Copy link
Owner

updatePlugin doesn't show updated test scripts until you refresh the page

I'll fix this soon.

flawiddsouza added a commit that referenced this pull request Oct 11, 2024
… > updatePlugin doesn't show updated test scripts until you refresh the page
@flawiddsouza
Copy link
Owner

Hey @kobenguyent, the above is fixed: 36d22ea. I think the issue happens because of how we load script data in Request Panel. But that's not an issue as we can just directly update the code as you update it for the snippet dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - generate test scripts
2 participants