Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): disable export when collection is empty #251

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

kobenguyent
Copy link
Collaborator

resolves #230

Screenshot 2024-09-24 at 17 19 29

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 2e51c91
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66f3a60a2153a00008e50df1
😎 Deploy Preview https://deploy-preview-251--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

image
This seems like extra processing when not needed. You can use this.$store.state.collection.length instead. It will have the same data. As this is just for disabling the export button.

@flawiddsouza
Copy link
Owner

image
Make it a computed property instead of using a data property - this will allow collectionLength to be dynamic. No need to use beforeMount.

@flawiddsouza flawiddsouza merged commit 4030a51 into main Sep 25, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-disable-export branch September 25, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling the export function when the workspace is empty.
2 participants