Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Request Panel > Request Header > Script indicator #196

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

kobenguyent
Copy link
Collaborator

would be a great UI/UX addition to let user acknowledge if there is any script added.

Screen.Recording.2024-07-25.at.12.02.38.mov

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit bb25f71
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66a25d743dc334000765f8b2
😎 Deploy Preview https://deploy-preview-196--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Heyo, feature seems good. The dot looks quite big in your recording but it's small when displayed on my system. Not sure why there's a variation in size. I'm on a Windows pc, using chrome.

The green color looks a bit dull. Can we have a brighter green?

image

image

image

@kobenguyent
Copy link
Collaborator Author

Heyo, feature seems good. The dot looks quite big in your recording but it's small when displayed on my system. Not sure why there's a variation in size. I'm on a Windows pc, using chrome.

The green color looks a bit dull. Can we have a brighter green?

image

image

image

oh, I think using fa icon would be more consistent across.
Screenshot 2024-07-25 at 15 37 51

@flawiddsouza
Copy link
Owner

image
Space after colon is missing.

image
this. can be removed from here

@flawiddsouza
Copy link
Owner

Just noticed that completely removing the display: inline in active-script class makes no difference to the ui. Can you check if it's required?

@kobenguyent
Copy link
Collaborator Author

updated as proposed.

@flawiddsouza flawiddsouza merged commit fee195d into main Jul 25, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-script-indicator branch July 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants