Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): revamp the response history list #175

Merged
merged 9 commits into from
Jul 6, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jul 5, 2024

resolves #164

UI.Improvement.Response.History.webm

Screenshot 2024-07-05 at 09 49 53

@kobenguyent kobenguyent linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit db118f0
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66894deae9af8b0008ff1f9e
😎 Deploy Preview https://deploy-preview-175--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kobenguyent kobenguyent added question Further information is requested UI and removed question Further information is requested labels Jul 5, 2024
@flawiddsouza
Copy link
Owner

Heyo, this is broken:
image

@kobenguyent
Copy link
Collaborator Author

uh oh, I haven't noticed this. Shall be fixed for now.
Screenshot 2024-07-05 at 10 32 53

@flawiddsouza
Copy link
Owner

image
Every response I select now says 2 hours ago here above, which is not very useful to id the request even though I did make the requests 2 hours ago. Before we used to be able to see hh:mm:ss, which helped with differentiating the response history selection. The url being there also helped when you switched environments and were checking responses.

@kobenguyent
Copy link
Collaborator Author

kobenguyent commented Jul 5, 2024

sure, could add the date time and url after time ago.

Screenshot 2024-07-05 at 13 41 34

@flawiddsouza
Copy link
Owner

image
Looks good. Can we have | as separator instead of - after x seconds ago, so the separator is consistent?

@kobenguyent
Copy link
Collaborator Author

image Looks good. Can we have | as separator instead of - after x seconds ago, so the separator is consistent?

sure!

@flawiddsouza
Copy link
Owner

image
Let's keep the z-index at 1. Any reason you changed it to 1000? Because it seems to work the same.

Also padding property. I prefer keeping it explicit since we're setting on padding top and bottom. padding 5px 0 works the same but I always forget which is which, as do a lot of people.

image
Always keep the css scoped inside a vue component. Else the css styles can accidentally apply to other things.

image
Remove this blank line.

image
These should be one after the other, instead of in the same line.

@flawiddsouza flawiddsouza merged commit 0e5548b into main Jul 6, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the 164-ui-improvement-response-history branch July 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Improvement > Response History
2 participants