Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: xml response filtering #152

Merged

Conversation

kobenguyent
Copy link
Collaborator

Copy link

netlify bot commented May 15, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit c4a6687
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/6644762e9a7ca40008588146
😎 Deploy Preview https://deploy-preview-152--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 4d31c5e
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/6644abc9e325e4000848f978
😎 Deploy Preview https://deploy-preview-152--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Heyo, xmldom depedency might not be required. Can you check if you can use this instead: https://developer.mozilla.org/en-US/docs/Web/API/DOMParser? There's a native api.

@kobenguyent
Copy link
Collaborator Author

Heyo, xmldom depedency might not be required. Can you check if you can use this instead: https://developer.mozilla.org/en-US/docs/Web/API/DOMParser? There's a native api.

yeah, sure. Updated.

@flawiddsouza
Copy link
Owner

image
Keep the conditions as v-else-if instead of v-if. Also keep a v-else at the end with CodeMirrorResponsePanelPreview to display responses that don't match any content types. Earlier if there was an unmwatched content type, it would get displayed in a CodeMirrorResponsePanelPreview component. Now there's no else to handle this case.

@flawiddsouza
Copy link
Owner

Looks good 👍

@flawiddsouza flawiddsouza merged commit 3eabd2c into flawiddsouza:main May 15, 2024
6 checks passed
@kobenguyent kobenguyent deleted the feat/xml-response-filtering branch May 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response panel > xml response filtering
2 participants