Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ui): custom request method dropdown #150

Merged

Conversation

kobenguyent
Copy link
Collaborator

resolves #147

custom.dropdown.mov

Copy link

netlify bot commented May 14, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 4d312f0
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/664385ea0f785f00084f0bce
😎 Deploy Preview https://deploy-preview-150--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Any reason to put the css in main.css? Also try to give a .class when overriding default styling like ul and so on:
image

The hover color doesn't look right in dark mode.
image
Refer context menu for hover color in dark mode:
image
There should be a css variable for the same.
Also that white border needs to change in dark mode.

The light mode looks pretty good. No changes needed there.

Another thing. When you select a method now, the url keeps jumping forward and background. Can you set a fixed width for the method dropdown so it doesn't change the layout?

@flawiddsouza
Copy link
Owner

Also add a bit of left padding to the method selector, so it isn't almost touching the edge of the container.
image
Something like:
image

@flawiddsouza
Copy link
Owner

Looks good. Use var(--default-border-radius) instead of hardcoded border radius:
image

@flawiddsouza
Copy link
Owner

Let's align the dropdown with the dropdown text:

From:
image
To:
image
image

@flawiddsouza flawiddsouza merged commit fab8069 into flawiddsouza:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI improvement - Request method list with according color
2 participants