Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ui): Improve dark theme #140

Merged
merged 12 commits into from
May 11, 2024
Merged

Conversation

mofazhe
Copy link
Contributor

@mofazhe mofazhe commented May 10, 2024

The modifications are as follows:

  1. menu supports dark
  2. dialog supports dark
  3. menu icon of EnvironmentModal supports dark
  4. alert confirm prompt supports dark
  5. tip text of SidebarSettingsModal supports dark

The preview is as follows:

image
image
image
image
image

Copy link

netlify bot commented May 10, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 45a7fed
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/663f16dcdaac58000822bf56
😎 Deploy Preview https://deploy-preview-140--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Looks good.

Can we retain the original look of the prompt modal for the focus, button colors + button text at least for the light mode?

Before:
image

After:
image

It used to look good. The current version looks fine for the dark mode but looks a bit dull for the light mode.

@mofazhe
Copy link
Contributor Author

mofazhe commented May 10, 2024

  1. Improved button style for this dialog
  2. Enable focus highlighting for most input

I removed the outline of the input before because the dark mode looked a bit weird, but now I have improved it.

Please check again.

image
image
image
image

@flawiddsouza
Copy link
Owner

Thanks. That looks much better.

You can revert this change:
image

image
You can use fill: white or any other color to get the required color for dark mode. The existing svg looks a lot better than the icon from fa.


The modal footer used to have a slightly darker background color:
Before:
image
After:
image
Can you keep that?

You should be able to retain the old css with a little change for dark mode. It had its own css variable called soft-color:
image


I want to retain the lighter border color of the context menu:
Before:
image
After:
image
When context menus overlap with the borders of the application, I wanted it to pop out a bit. Now the borders blend more together.

That'll be all the changes. Then it should be good for merge.

@flawiddsouza
Copy link
Owner

One more thing I just noticed:
Before:
image
After:
image
The lighter borders looked better for inputs. Can you keep the original here as well?

@mofazhe
Copy link
Contributor Author

mofazhe commented May 11, 2024

I have made changes to these, please check it.

For soft-color, as an alternative, I have added --modal-footer-background-color in the global style. I think this will better cover future theme modifications and additions.

@flawiddsouza
Copy link
Owner

Everything seems good now. Thanks for the PR.

@flawiddsouza flawiddsouza merged commit adf527c into flawiddsouza:main May 11, 2024
6 checks passed
@mofazhe mofazhe deleted the perf/dark-theme branch June 20, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants