cmake: only use MSYS/NMake generators when available #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanhu Thanks for this! I kicked off CI but looks like there are some test failures. |
stanhu
force-pushed
the
sh-cmake-msys
branch
2 times, most recently
from
943ebf3 to
19d9913
Compare
stanhu
commented
Jul 17, 2023
|
This looks OK to me. @stanhu do you want to write a CHANGELOG entry, and then I can merge and cut a point release for you? |
|
@flavorjones Sure, should I mark this as v2.9.0? |
flavorjones
requested changes
Jul 17, 2023
When cross-compiling Windows targets with `cmake` in a Linux environment, the MSYS generator may not be available. Supplying `-G MSYS` will cause the build to fail. `cmake --help` will output the available generators. Before including the `-G` option, check that the generator is available. Closes flavorjones#127
flavorjones
reviewed
Jul 17, 2023
flavorjones
approved these changes
Jul 17, 2023
stanhu
added a commit
to stanhu/re2
that referenced
this pull request
Jul 18, 2023
This pulls in flavorjones/mini_portile#129. When cross-compiling Windows targets with cmake in a Linux environment, the MSYS generator may not be available. Supplying -G MSYS will cause the build to fail.
mudge
pushed a commit
to mudge/re2
that referenced
this pull request
Jul 25, 2023
This pulls in flavorjones/mini_portile#129. When cross-compiling Windows targets with cmake in a Linux environment, the MSYS generator may not be available. Supplying -G MSYS will cause the build to fail.
mudge
pushed a commit
to mudge/re2
that referenced
this pull request
Sep 13, 2023
This pulls in flavorjones/mini_portile#129. When cross-compiling Windows targets with cmake in a Linux environment, the MSYS generator may not be available. Supplying -G MSYS will cause the build to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling Windows targets with
cmakein a Linux environment, the MSYS generator may not be available. Supplying-G MSYSwill cause the build to fail.cmake --helpwill output the available generators. Before including the-Goption, check that the generator is available.Closes #127