Prepare 1.2.0 release (ansible-collections#208)

* Prepare 1.2.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Bump required amazon.aws release in test requirements * Manually remove extraneous single quote on aws_kms line from 1.0.0
flavioelawi · Aug 28, 2020 · 315f546 · 315f546
1 parent 00a7660
commit 315f546
Show file tree

Hide file tree

Showing 185 changed files with 2,668 additions and 814 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -5,6 +5,24 @@ community.aws Release Notes
 .. contents:: Topics
 
 
+v1.2.0
+======
+
+Minor Changes
+-------------
+
+- Add retries for aws_api_gateway when AWS throws `TooManyRequestsException`
+- Migrate the remaning boto3 based modules to the module based helpers for creating AWS connections.
+
+Bugfixes
+--------
+
+- aws_codecommit - fixes issue where module execution would fail if an existing repository has empty description (https://github.com/ansible-collections/community.aws/pull/195)
+- aws_kms_info - fixes issue where module execution fails because certain AWS KMS keys (e.g. aws/acm) do not permit the calling the API kms:GetKeyRotationStatus (example - https://forums.aws.amazon.com/thread.jspa?threadID=312992) (https://github.com/ansible-collections/community.aws/pull/199)
+- ec2_instance - Fix a bug where tags were updated in check_mode.
+- ec2_instance - fixes issue where security groups were not changed if the instance already existed.  https://github.com/ansible-collections/community.aws/pull/22
+- iam - Fix false positive warning regarding use of ``no_log`` on ``update_password``
+
 v1.1.0
 ======
 
@@ -19,14 +37,14 @@ Deprecated Features
 
 - data_pipeline - the ``version`` option has been deprecated and will be removed in a later release. It has always been ignored by the module.
 - ec2_eip - the ``wait_timeout`` option has been deprecated and will be removed in a later release. It has had no effect since Ansible 2.3.
-- ec2_lc - the ``associate_public_ip_address`` option has been deprecated and will be removed in a later release. It has always been ignored by the module.
+- ec2_lc - the ``associate_public_ip_address`` option has been deprecated and will be removed after a later release. It has always been ignored by the module.
 - elb_network_lb - in a later release, the default behaviour for the ``state`` option will change from ``absent`` to ``present``.  To maintain the existing behavior explicitly set state to ``absent``.
-- iam_managed_policy - the ``fail_on_delete`` option has been deprecated and will be removed in a later release.  It has always been ignored by the module.
+- iam_managed_policy - the ``fail_on_delete`` option has been deprecated and will be removed after a later release.  It has always been ignored by the module.
 - iam_policy - in a later release, the default value for the ``skip_duplicates`` option will change from ``true`` to ``false``.  To maintain the existing behavior explicitly set it to ``true``.
-- iam_policy - the ``policy_document`` option has been deprecated and will be removed in a later release. To maintain the existing behavior use the ``policy_json`` option and read the file with the ``lookup`` plugin.
+- iam_policy - the ``policy_document`` option has been deprecated and will be removed after a later release. To maintain the existing behavior use the ``policy_json`` option and read the file with the ``lookup`` plugin.
 - iam_role - in a later release, the ``purge_policies`` option (also know as ``purge_policy``) default value will change from ``true`` to ``false``
-- s3_lifecycle - the ``requester_pays`` option has been deprecated and will be removed in a later release. It has always been ignored by the module.
-- s3_sync - the ``retries`` option has been deprecated and will be removed in a later release. It has always been ignored by the module.
+- s3_lifecycle - the ``requester_pays`` option has been deprecated and will be removed after a later release. It has always been ignored by the module.
+- s3_sync - the ``retries`` option has been deprecated and will be removed after 2022-06-01. It has always been ignored by the module.
 
 v1.0.0
 ======
@@ -39,10 +57,10 @@ Minor Changes
 - aws_acm - Update automatic retries to stabilize the integration tests.
 - aws_codecommit - Support updating the description
 - aws_kms - Adds the ``enable_key_rotation`` option to enable or disable automatically key rotation.
-- aws_kms: code refactor, some error messages updated
+- aws_kms - code refactor, some error messages updated
 - aws_kms_info - Adds the ``enable_key_rotation`` info to the return value.
-- ec2_asg - Add the ability to use mixed_instance_policy in launch template driven autoscaling groups
 - ec2_asg - Add support for Max Instance Lifetime
+- ec2_asg - Add the ability to use mixed_instance_policy in launch template driven autoscaling groups
 - ec2_asg - Migrated to AnsibleAWSModule
 - ec2_placement_group - make ``name`` a required field.
 - ecs_task_definition - Add network_mode=default to support Windows ECS tasks.
@@ -74,7 +92,7 @@ Deprecated Features
 - ec2_key - The ``wait_timeout`` option had no effect and will be removed after 2022-06-01
 - ec2_key - The ``wait`` option had no effect and will be removed after 2022-06-01
 - ec2_lc - The ``associate_public_ip_address`` option had no effect and will be removed after 2022-06-01
-- elb_network_lb: The current default value of the ``state`` option has been deprecated and will change from absent to present after 2022-06-01
+- elb_network_lb - The current default value of the ``state`` option has been deprecated and will change from absent to present after 2022-06-01
 - iam_managed_policy - The ``fail_on_delete`` option had no effect and will be removed after 2022-06-01
 - iam_policy - The ``policy_document`` will be removed after 2022-06-01.  To maintain the existing behavior use the ``policy_json`` option and read the file with the ``lookup`` plugin.
 - iam_policy - The default value of ``skip_duplicates`` will change after 2022-06-01 from ``true`` to ``false``.
@@ -96,7 +114,7 @@ Bugfixes
 - cloudfront_distribution - Always add field_level_encryption_id to cache behaviour to match AWS requirements
 - cloudwatchlogs_log_group - Fix a KeyError when updating a log group that does not have a retention period (https://github.com/ansible/ansible/issues/47945)
 - cloudwatchlogs_log_group_info - remove limitation of max 50 results
-- ec2_asg: Ensure "wait" is honored during replace operations
+- ec2_asg - Ensure "wait" is honored during replace operations
 - ec2_launch_template - Update output to include latest_version and default_version, matching the documentation
 - ec2_transit_gateway - Use AWSRetry before ClientError is handled when describing transit gateways
 - ec2_transit_gateway - fixed issue where auto_attach set to yes was not being honored (https://github.com/ansible/ansible/issues/61907)

diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml
@@ -77,11 +77,11 @@ releases:
       - aws_codecommit - Support updating the description
       - aws_kms - Adds the ``enable_key_rotation`` option to enable or disable automatically
         key rotation.
-      - aws_kms - code refactor, some error messages updated'
+      - aws_kms - code refactor, some error messages updated
       - aws_kms_info - Adds the ``enable_key_rotation`` info to the return value.
+      - ec2_asg - Add support for Max Instance Lifetime
       - ec2_asg - Add the ability to use mixed_instance_policy in launch template
         driven autoscaling groups
-      - ec2_asg - Add support for Max Instance Lifetime
       - ec2_asg - Migrated to AnsibleAWSModule
       - ec2_placement_group - make ``name`` a required field.
       - ecs_task_definition - Add network_mode=default to support Windows ECS tasks.
@@ -683,7 +683,8 @@ releases:
         option will change from ``absent`` to ``present``.  To maintain the existing
         behavior explicitly set state to ``absent``.
       - iam_managed_policy - the ``fail_on_delete`` option has been deprecated and
-        will be removed after a later release.  It has always been ignored by the module.
+        will be removed after a later release.  It has always been ignored by the
+        module.
       - iam_policy - in a later release, the default value for the ``skip_duplicates``
         option will change from ``true`` to ``false``.  To maintain the existing behavior
         explicitly set it to ``true``.
@@ -704,3 +705,28 @@ releases:
     - porting-guide.yml
     - sanity_fix_future_boilerplate.yml
     release_date: '2020-08-13'
+  1.2.0:
+    changes:
+      bugfixes:
+      - aws_codecommit - fixes issue where module execution would fail if an existing
+        repository has empty description (https://github.com/ansible-collections/community.aws/pull/195)
+      - aws_kms_info - fixes issue where module execution fails because certain AWS
+        KMS keys (e.g. aws/acm) do not permit the calling the API kms:GetKeyRotationStatus
+        (example - https://forums.aws.amazon.com/thread.jspa?threadID=312992) (https://github.com/ansible-collections/community.aws/pull/199)
+      - ec2_instance - Fix a bug where tags were updated in check_mode.
+      - ec2_instance - fixes issue where security groups were not changed if the instance
+        already existed.  https://github.com/ansible-collections/community.aws/pull/22
+      - iam - Fix false positive warning regarding use of ``no_log`` on ``update_password``
+      minor_changes:
+      - Add retries for aws_api_gateway when AWS throws `TooManyRequestsException`
+      - Migrate the remaning boto3 based modules to the module based helpers for creating
+        AWS connections.
+    fragments:
+    - 161-retries.yml
+    - 188-boto3_conn.yml
+    - 189-ec2_instance-check_mode-tags.yml
+    - 195-aws_codecommit-empty-description.yaml
+    - 199-aws_kms_info-key-rotation-status.yaml
+    - 22-ec2_instance-mod-sgs.yml
+    - iam_no_log.yml
+    release_date: '2020-08-28'
diff --git a/changelogs/fragments/161-retries.yml b/changelogs/fragments/161-retries.yml
diff --git a/changelogs/fragments/188-boto3_conn.yml b/changelogs/fragments/188-boto3_conn.yml
diff --git a/changelogs/fragments/189-ec2_instance-check_mode-tags.yml b/changelogs/fragments/189-ec2_instance-check_mode-tags.yml
diff --git a/changelogs/fragments/195-aws_codecommit-empty-description.yaml b/changelogs/fragments/195-aws_codecommit-empty-description.yaml
diff --git a/changelogs/fragments/199-aws_kms_info-key-rotation-status.yaml b/changelogs/fragments/199-aws_kms_info-key-rotation-status.yaml
diff --git a/changelogs/fragments/22-ec2_instance-mod-sgs.yml b/changelogs/fragments/22-ec2_instance-mod-sgs.yml
diff --git a/changelogs/fragments/iam_no_log.yml b/changelogs/fragments/iam_no_log.yml
diff --git a/docs/community.aws.aws_acm_info_module.rst b/docs/community.aws.aws_acm_info_module.rst
@@ -38,7 +38,7 @@ Parameters
 .. raw:: html
 
     <table  border=0 cellpadding=0 class="documentation-table">
-    <tr>
+        <tr>
             <th colspan="1">Parameter</th>
             <th>Choices/<font color="blue">Defaults</font></th>
             <th width="100%">Comments</th>
@@ -56,6 +56,8 @@ Parameters
                 </td>
                 <td>
                         <div>AWS access key. If not set then the value of the AWS_ACCESS_KEY_ID, AWS_ACCESS_KEY or EC2_ACCESS_KEY environment variable is used.</div>
+                        <div>If <em>profile</em> is set this parameter is ignored.</div>
+                        <div>Passing the <em>aws_access_key</em> and <em>profile</em> options at the same time has been deprecated and the options will be made mutually exclusive after 2022-06-01.</div>
                         <div style="font-size: small; color: darkgreen"><br/>aliases: ec2_access_key, access_key</div>
                 </td>
             </tr>
@@ -106,6 +108,8 @@ Parameters
                 </td>
                 <td>
                         <div>AWS secret key. If not set then the value of the AWS_SECRET_ACCESS_KEY, AWS_SECRET_KEY, or EC2_SECRET_KEY environment variable is used.</div>
+                        <div>If <em>profile</em> is set this parameter is ignored.</div>
+                        <div>Passing the <em>aws_secret_key</em> and <em>profile</em> options at the same time has been deprecated and the options will be made mutually exclusive after 2022-06-01.</div>
                         <div style="font-size: small; color: darkgreen"><br/>aliases: ec2_secret_key, secret_key</div>
                 </td>
             </tr>
@@ -191,6 +195,8 @@ Parameters
                 </td>
                 <td>
                         <div>Uses a boto profile. Only works with boto &gt;= 2.24.0.</div>
+                        <div>Using <em>profile</em> will override <em>aws_access_key</em>, <em>aws_secret_key</em> and <em>security_token</em> and support for passing them at the same time as <em>profile</em> has been deprecated.</div>
+                        <div><em>aws_access_key</em>, <em>aws_secret_key</em> and <em>security_token</em> will be made mutually exclusive with <em>profile</em> after 2022-06-01.</div>
                         <div style="font-size: small; color: darkgreen"><br/>aliases: aws_profile</div>
                 </td>
             </tr>
@@ -223,6 +229,8 @@ Parameters
                 </td>
                 <td>
                         <div>AWS STS security token. If not set then the value of the AWS_SECURITY_TOKEN or EC2_SECURITY_TOKEN environment variable is used.</div>
+                        <div>If <em>profile</em> is set this parameter is ignored.</div>
+                        <div>Passing the <em>security_token</em> and <em>profile</em> options at the same time has been deprecated and the options will be made mutually exclusive after 2022-06-01.</div>
                         <div style="font-size: small; color: darkgreen"><br/>aliases: aws_security_token, access_token</div>
                 </td>
             </tr>
@@ -233,7 +241,8 @@ Parameters
                     <a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
                     <div style="font-size: small">
                         <span style="color: purple">list</span>
- / <span style="color: purple">elements=string</span>                    </div>
+                         / <span style="color: purple">elements=string</span>
+                    </div>
                 </td>
                 <td>
                         <ul style="margin: 0; padding: 0"><b>Choices:</b>
@@ -292,7 +301,7 @@ Notes
 -----
 
 .. note::
-   - If parameters are not set within the module, the following environment variables can be used in decreasing order of precedence ``AWS_URL`` or ``EC2_URL``, ``AWS_ACCESS_KEY_ID`` or ``AWS_ACCESS_KEY`` or ``EC2_ACCESS_KEY``, ``AWS_SECRET_ACCESS_KEY`` or ``AWS_SECRET_KEY`` or ``EC2_SECRET_KEY``, ``AWS_SECURITY_TOKEN`` or ``EC2_SECURITY_TOKEN``, ``AWS_REGION`` or ``EC2_REGION``, ``AWS_PROFILE`` or ``AWS_DEFAULT_PROFILE``, ``AWS_CA_BUNDLE``
+   - If parameters are not set within the module, the following environment variables can be used in decreasing order of precedence ``AWS_URL`` or ``EC2_URL``, ``AWS_PROFILE`` or ``AWS_DEFAULT_PROFILE``, ``AWS_ACCESS_KEY_ID`` or ``AWS_ACCESS_KEY`` or ``EC2_ACCESS_KEY``, ``AWS_SECRET_ACCESS_KEY`` or ``AWS_SECRET_KEY`` or ``EC2_SECRET_KEY``, ``AWS_SECURITY_TOKEN`` or ``EC2_SECURITY_TOKEN``, ``AWS_REGION`` or ``EC2_REGION``, ``AWS_CA_BUNDLE``
    - Ansible uses the boto configuration file (typically ~/.boto) if no credentials are provided. See https://boto.readthedocs.io/en/latest/boto_config_tut.html
    - ``AWS_REGION`` or ``EC2_REGION`` can be typically be used to specify the AWS region, when required, but this can also be configured in the boto config file
 
@@ -509,7 +518,8 @@ Common return values are documented `here <https://docs.ansible.com/ansible/late
                     <a class="ansibleOptionLink" href="#return-" title="Permalink to this return value"></a>
                     <div style="font-size: small">
                       <span style="color: purple">list</span>
- / <span style="color: purple">elements=string</span>                    </div>
+                       / <span style="color: purple">elements=string</span>
+                    </div>
                 </td>
                 <td>always</td>
                 <td>
@@ -565,7 +575,8 @@ Common return values are documented `here <https://docs.ansible.com/ansible/late
                     <a class="ansibleOptionLink" href="#return-" title="Permalink to this return value"></a>
                     <div style="font-size: small">
                       <span style="color: purple">list</span>
- / <span style="color: purple">elements=string</span>                    </div>
+                       / <span style="color: purple">elements=string</span>
+                    </div>
                 </td>
                 <td>always</td>
                 <td>
@@ -746,7 +757,8 @@ Common return values are documented `here <https://docs.ansible.com/ansible/late
                     <a class="ansibleOptionLink" href="#return-" title="Permalink to this return value"></a>
                     <div style="font-size: small">
                       <span style="color: purple">list</span>
- / <span style="color: purple">elements=string</span>                    </div>
+                       / <span style="color: purple">elements=string</span>
+                    </div>
                 </td>
                 <td>always</td>
                 <td>
@@ -913,7 +925,8 @@ Common return values are documented `here <https://docs.ansible.com/ansible/late
                     <a class="ansibleOptionLink" href="#return-" title="Permalink to this return value"></a>
                     <div style="font-size: small">
                       <span style="color: purple">list</span>
- / <span style="color: purple">elements=string</span>                    </div>
+                       / <span style="color: purple">elements=string</span>
+                    </div>
                 </td>
                 <td>always</td>
                 <td>