.NET 7 Support #109
.NET 7 Support #109
Conversation
This enables spawning host processes via flatpak-spawn by creating wrapper scripts in /app/bin and changes the default editor preference paths to the correct values. Both utilities must be installed on the host and be accessible via PATH environment variable. Closes flathub#15 Closes godotengine/godot-website#60 http://docs.flatpak.org/en/latest/flatpak-command-reference.html#flatpak-spawn
Co-authored-by: Hugo Locurcio <[email protected]>
<a> links aren't supported, so we have to use plain text links instead.
- Remove Android export patch due to the new export system in 3.3. Exporting for Android will no longer be possible from the Flatpak until it's reimplemented for the new system: https://docs.godotengine.org/en/latest/tutorials/export/exporting_for_android.html - Remove redundant i386 release optimization patch (we don't build export templates anymore).
|
Started test build 44449 |
|
Build 44449 failed |
|
Started test build 44454 |
|
Build 44454 successful |
Update Godot to 4.1 (flathub#126)
|
Started test build 51868 |
|
Started test build 51869 |
|
Build 51868 failed |
|
Build 51869 successful |
Using GitHub link to source download this time as it hasn't been uploaded to TuxFamily yet
|
Started test build 54316 |
|
Build 54316 failed |
|
Started test build 54325 |
|
Build 54325 successful |
This is not available anymore 404 😭 |
|
I'm not really interested in maintaining this PR at the moment for a variety of reasons. Between long build times and the lack of version management (an equivalent to Unity Hub really), I don't really like running the engine itself as a Flatpak. Once Godot eventually unifies the C# and non-C# builds, I will probably come back to finish this PR, but that could be a long time from now. If anyone needs C# support now, I would recommend something like my Godots Flatpak if C# support is something you do need, as it aggregates both non-C# and C# builds of Godot, as well as multiple different versions. Or run a container with Godot and .NET in it, and use Visual Studio Code's Dev Container extension to connect to it. |
I was actually considering reorganising the commits in your PR by copying them to my fork of the Flathub repository used for submitting new Flatpaks, so that the C# builds (both 3 and 4) could, potentially, go up on Flathub as separate Flatpaks, so that those who need them can still install them. I personally think it's better to include the C# builds on Flathub separately from the standard builds as Calinou suggested, at least until the C# and non-C# builds finally get unified. I'd just like to request your permission to do so (from both you and Calinou), and when I do get round to it (if I have your permission, of course), I'll make sure to let you and Calinou know here when I've opened those PRs. I managed to get the standard Godot 3 build uploaded to Flathub, so I have a little bit of experience with getting new Flatpaks up on Flathub. I'll also need to create a PR for flatpak-builder-lint so that support for external code editors can be retained for both Flatpaks. @CharlieQLe @Calinou sorry for the pings. Please can you let me know if you think what I'm suggesting here is a good idea and whether or not I should action it? I'd appreciate any advice you both have. Also, Charlie, your Godots Flatpak could potentially also go up on Flathub, in my humble opinion. I didn't even know a Godot version manager even existed until now! |
|
@Zishan-Rahman Go for it! A separate C# flatpak would be a good thing to see for people just getting into Godot that need a Flatpak, though it should be noted that the custom dotnet editors isn't supported afaik. |
|
@CharlieQLe @Calinou Sorry for the pings and for the late reply to Charlie's comment. I just set up PRs on Flathub's new app submission repo for versions of Godot 3 and Godot 4 with .NET support. Godot 4's .NET version should be relatively straightforward, since that's what the latest revisions in Charlie's PR were based on anyway. Godot 3's .NET version l'll likely need some help with to make sure everything works, since I'm not very familiar with the .NET and Mono ecosystems at the moment. I have therefore set up a repo of my own using commit histories from this PR and the Godot 3 Flatpak, and I have sent both of you collaboration invites so that you can help if and when you can. Each time a change is pushed there, I'll push that change to the branch in my fork of flathub/flathub used for the Godot 3 .NET Flatpak build. I'll appreciate it a lot if you could please accept these invites as soon as possible, so that we can fix any issues and hopefully get these Flatpaks submitted to Flathub as soon as possible. Here's the Godot 4 PR: flathub/flathub#4594 |
|
@CharlieQLe @Calinou (sorry for the pings) It took a while, but we finally got the C# Godot 4 build on Flathub: https://flathub.org/apps/org.godotengine.GodotSharp Godot 3's C# Flatpak is still a work-in-progress as of now, but for Godot 4's C# build, it looks like we can close this PR. @CharlieQLe Thanks for all your hard work in setting this up and continuing to maintain it until now! I don't know if you've been invited to maintain the new Flatpak as a collaborator, so if you haven't, we could always create an issue on the flathub/flathub repository to have you added as one. |
|
Closing per the above comment. Thanks a ton for the contribution 🙂 |
This is still unfinished, since I still need to figure out a location for the local nuget source that contains
Godot-SDK. Other than that, I expect this to work fine, but I have not yet tested a build. Once completed, this should fix #8 .