Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app and runtime #9

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Conversation

wjt
Copy link
Member

@wjt wjt commented Jul 18, 2022

Fixes #6 inasmuch as it builds.
Fixes #7 except a newer runtime.

This will be needed for intltool in a future commit.
@flathubbot
Copy link
Contributor

Started test build 101222

org.gnome.gbrainy.json Outdated Show resolved Hide resolved
org.gnome.gbrainy.json Outdated Show resolved Hide resolved
org.gnome.gbrainy.json Outdated Show resolved Hide resolved
@flathubbot
Copy link
Contributor

Build 101222 failed

wjt added 2 commits July 18, 2022 22:10
A future commit will add flatpak-external-data-checker annotations, and
fedc will reformat this file slightly.
@flathubbot
Copy link
Contributor

Started test build 101286

@flathubbot
Copy link
Contributor

Build 101286 was cancelled

wjt and others added 4 commits July 18, 2022 22:26
This fails to build for reasons fixed in a future commit.
This fixes the following build error:

    Making all in tools
    make[2]: Entering directory '/run/build/gbrainy/tools'
    /usr/lib/sdk/mono6/bin/mcs -target:winexe -out:GameXmlToGetString.exe  ./GameXmlToGetString.cs -r:../src/gbrainy.Core.dll -r:Mono.Posix
    export MONO_PATH=../src && /usr/lib/sdk/mono6/bin/mono GameXmlToGetString.exe .

    Unhandled Exception:
    System.TypeLoadException: Could not set up parent class, due to: Could not load type of field 'gbrainy.Core.Main.Game:default_color' (0) due to: Could not load file or assembly 'cairo-sharp, Version=1.10.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756' or one of its dependencies. assembly:/run/build/gbrainy/src/gbrainy.Core.dll type:Game member:(null)
      at GameXmlToGetString.Main (System.String[] args) [0x00061] in <2326c82eb00343b4a364a997caa15399>:0
    [ERROR] FATAL UNHANDLED EXCEPTION: System.TypeLoadException: Could not set up parent class, due to: Could not load type of field 'gbrainy.Core.Main.Game:default_color' (0) due to: Could not load file or assembly 'cairo-sharp, Version=1.10.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756' or one of its dependencies. assembly:/run/build/gbrainy/src/gbrainy.Core.dll type:Game member:(null)
      at GameXmlToGetString.Main (System.String[] args) [0x00061] in <2326c82eb00343b4a364a997caa15399>:0

I think the problem is that the gtk-sharp build step is adding the
.dll to (a subdirectory of) /app, but because Mono is being run from (a
subdirectory of) /usr that path is not in Mono's search path.
Flathub passes this on the CLI; and it is desirable for local builds to
use a clearly different branch.
gbrainy uses this to play sounds. Without it you see the following on
stderr when gbrainy tries to play a sound:

    Unix.PlaySound. Error System.DllNotFoundException: libcanberra-gtk3.so.0 assembly:<unknown assembly> type:<unknown type> member:(null)
      at (wrapper managed-to-native) gbrainy.Core.Platform.Unix.ca_gtk_play_for_widget(intptr,uint,string,string,string,string,intptr)
      at gbrainy.Core.Platform.Unix.PlaySound (System.IntPtr widget, System.String filename) [0x00000] in <c1cbe592d22c4597a90c664ab477780f>:0
@wjt wjt marked this pull request as ready for review July 18, 2022 21:27
@wjt
Copy link
Member Author

wjt commented Jul 18, 2022

Cracked it!

@flathubbot
Copy link
Contributor

Started test build 101288

@wjt wjt changed the title WIP: Update app and runtime Update app and runtime Jul 18, 2022
@flathubbot
Copy link
Contributor

Build 101288 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99024/org.gnome.gbrainy.flatpakref

@wjt
Copy link
Member Author

wjt commented Jul 19, 2022

Test build works on my machine™

@jordimas
Copy link
Collaborator

Thanks, really appreciated

@jordimas jordimas merged commit fa39137 into flathub:master Jul 20, 2022
@wjt wjt deleted the update-app-and-runtime branch July 20, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update runtime to 3.38 Doesn't build, didn't find mono5 in 19.08
4 participants