Add libfuse #201
Closed
Add libfuse #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 72570 |
|
Build 72570 failed |
@A6GibKm The way this build errored with endless Do you know the reason/ a fix for this? Edit: The same issue is happening in #199 currently |
|
bot, build net.lutris.Lutris |
|
Queued test build for net.lutris.Lutris. |
|
Started test build 72638 |
|
Build 72638 failed |
|
bot, build net.lutris.Lutris |
|
Queued test build for net.lutris.Lutris. |
|
Started test build 73042 |
|
Build 73042 successful |
I am sorry, I don't know whats the cause, but it is building now. Did it fix the issue? |
It does fix the original issue, meaning I can start Appimages inside of lutris. I opened another issue to track the the build issues: #202 |
A6GibKm
reviewed
Jan 2, 2022
net.lutris.Lutris.yml
Outdated
| @@ -14,9 +14,11 @@ finish-args: | |||
| - --share=network | |||
| - --allow=multiarch | |||
| - --allow=devel | |||
| - --talk-name=org.freedesktop.Flatpak.* | |||
There was a problem hiding this comment.
Why it needs this line? Its for the wrapper? This is a somewhat dangerous hole in the sandbox.
There was a problem hiding this comment.
One alternative is to not add this hole and explicitly say how-to in the README.
There was a problem hiding this comment.
Why it needs this line? Its for the wrapper? This is a somewhat dangerous hole in the sandbox.
Appimages don't start without it and every other flatpak implementing fuse has this line.
Sadly I couldn't find out why exactly it needs this line.
One alternative is to not add this hole and explicitly say how-to in the README.
Yes, that might be a good idea.
I'm also not completely comfortable with how much it compromises the sandbox.
There was a problem hiding this comment.
Yeah, lets do that, that particular hole allows for arbitrary code execution.
Closes flathub#200 Closes flathub#198 Closes flathub#12
|
Started test build 85068 |
|
Build 85068 successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200
Closes #198
Closes #12
This is mostly copied from https://github.com/flathub/org.gnome.World.PikaBackup/blob/master/org.gnome.World.PikaBackup.yml
It does use flatpak-spawn to acces fusermount on the host, meaning it punches another hole into the sandbox.