Skip to content
This repository has been archived by the owner on Apr 25, 2022. It is now read-only.

Show addons on detail page #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Dec 24, 2021

image

I think I'm happy with this, not too sure if the homepage links work like this or if we should just remove them

Goes with flathub-infra/backend#86

@hfiguiere
Copy link

I don't see the audio plugins.

What does happen with, for example, org.ardour.Ardour.

Does it check the extension points from the manifest or just the appstream data?

@razzeee
Copy link
Member Author

razzeee commented Dec 24, 2021

image

As we use the appstream releases tag to figure out the last release, these might be quiet old, even, when the flathub packaging is newer.

@razzeee
Copy link
Member Author

razzeee commented Dec 24, 2021

Does it check the extension points from the manifest or just the appstream data?

It's looking for the extends tag in appstream.

Which plugin ids would you expect on ardour? Everything, that's linked to https://github.com/flathub/org.freedesktop.LinuxAudio.BaseExtension ?

@razzeee
Copy link
Member Author

razzeee commented Jan 11, 2022

While this needs a rebase, it now works correctly with the backend. Still, some apps get way too many addons, at least for how we display them. We might need to have some kind of extender or modal for these.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants