Use JSON encoders where possible

flatgrassdotnet · Nov 21, 2024 · 0b93c46 · 0b93c46
1 parent d2c86fa
commit 0b93c46
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/api/news/list.go b/api/news/list.go
@@ -16,12 +16,10 @@ func List(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	resp, err := json.Marshal(entries)
+	w.Header().Set("Content-Type", "application/json")
+	err = json.NewEncoder(w).Encode(entries)
 	if err != nil {
-		utils.WriteError(w, r, fmt.Sprintf("failed to marshal response: %s", err))
+		utils.WriteError(w, r, fmt.Sprintf("failed to encode response: %s", err))
 		return
 	}
-
-	w.Header().Set("Content-Type", "application/json")
-	w.Write(resp)
 }
diff --git a/api/packages/get.go b/api/packages/get.go
@@ -50,12 +50,10 @@ func Get(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	resp, err := json.Marshal(pkg)
+	w.Header().Set("Content-Type", "application/json")
+	err = json.NewEncoder(w).Encode(pkg)
 	if err != nil {
-		utils.WriteError(w, r, fmt.Sprintf("failed to marshal response: %s", err))
+		utils.WriteError(w, r, fmt.Sprintf("failed to encode response: %s", err))
 		return
 	}
-
-	w.Header().Set("Content-Type", "application/json")
-	w.Write(resp)
 }
diff --git a/api/packages/list.go b/api/packages/list.go
@@ -67,12 +67,10 @@ func List(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	resp, err := json.Marshal(list)
+	w.Header().Set("Content-Type", "application/json")
+	err = json.NewEncoder(w).Encode(list)
 	if err != nil {
-		utils.WriteError(w, r, fmt.Sprintf("failed to marshal response: %s", err))
+		utils.WriteError(w, r, fmt.Sprintf("failed to encode response: %s", err))
 		return
 	}
-
-	w.Header().Set("Content-Type", "application/json")
-	w.Write(resp)
 }