-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Omaha sha1 hash if available and Verify checksum after download, with retry #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
changed the title
Check Omaha sha1 hash if available
Check Omaha sha1 hash if available and Verify checksum after download, with retry
Jan 3, 2024
pothos
force-pushed
the
kai/sha1
branch
2 times, most recently
from
January 3, 2024 14:56
ff6ad75
to
3fc1a8d
Compare
This was referenced Jan 3, 2024
dongsupark
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
pothos
commented
Jan 5, 2024
Old Nebraska servers were missing the newly introduced sha256 attribute and might only serve paylads with the regular sha1 attribute set. The generic payload is also just using the regular sha1 attribute because at that time a different extension was used which holds the sha256 checksum for the generic payload. Support the regular Omaha sha1 hash for use with old Nebraska servers. This makes it also easy to test with the generic payload.
The self.verify_checksum(...) call's return value wasn't checked in the package download call. Even if we do it there we should rather move it into the retry loop and make it explicit whether we expect certain checksums or not. Check the checksum after the download, and also retry when it mismatches.
I've fixed all warnings and added running clippy in the CI, otherwise it's too easy to forget. |
dongsupark
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Omaha sha1 hash if available
Old Nebraska servers were missing the newly introduced sha256 attribute and might only serve paylads with the regular sha1 attribute set. The generic payload is also just using the regular sha1 attribute because at that time a different extension was used which holds the sha256 checksum for the generic payload.
Support the regular Omaha sha1 hash for use with old Nebraska servers. This makes it also easy to test with the generic payload.
Verify checksum after download, with retry
The self.verify_checksum(...) call's return value wasn't checked in the
package download call. Even if we do it there we should rather move it
into the retry loop and make it explicit whether we expect certain
checksums or not.
Check the checksum after the download, and also retry when it
mismatches.
How to use
Fixes #31
I think this is the last piece to start using it in Flatcar.
Testing done