bake.sh: Gate mksquashfs xattr exclusion behind version check #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/mksquashfs-version
branch
from
7ad8eb0 to
1d2adef
Compare
krnowak
reviewed
Apr 18, 2024
Old mksquashfs versions don't support the xattr exclusion that was added to prevent harmless warnings getting printed. To support old mksquashfs versions, gate this behind a version check.
pothos
force-pushed
the
kai/mksquashfs-version
branch
from
91c1e02 to
d1419fc
Compare
ader1990
reviewed
Oct 10, 2024
| VERMAJ=$(echo "${VER}" | cut -d . -f 1) | ||
| VERMIN=$(echo "${VER}" | cut -d . -f 2) | ||
| ARG=(-all-root -noappend) | ||
| if [ "${VERMAJ}" -gt 4 ] && [ "${VERMIN}" -gt 6 ]; then |
There was a problem hiding this comment.
The check should be if [[ "${VERMAJ}" -gt 4 || ( "${VERMAJ}" -eq 4 && "${VERMIN}" -gt 5 ) ]]; then ?
See:
https://github.com/plougher/squashfs-tools/blob/master/README-4.6.1#L37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old mksquashfs versions don't support the xattr exclusion that was added to prevent harmless warnings getting printed. To support old mksquashfs versions, gate this behind a version check.
How to use
Testing done
I tested
./create_wasmtime_sysext.sh 4.0.0 wasmtimewith a 4.6 version, and for an older version it was also tested