create_docker_sysext.sh: no containerd-shim in v23 and higher #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug with ONLY_DOCKER builds in create_docker_sysext.sh. Docker binary releases version 23 and above do not ship /usr/bin/containerd-shim anymore, leading to the following error when building a "docker only" sysext w/o containerd: rm: cannot remove 'docker/usr/bin/containerd-shim': No such file or directory This PR handles versions below major release 23 separately and ony deletes containerd-shim for these versions. Signed-off-by: Thilo Fromm <[email protected]>
krnowak
approved these changes
Oct 25, 2023
My first approach was to switch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug with ONLY_DOCKER builds in create_docker_sysext.sh. Docker binary releases version 23 and above do not ship /usr/bin/containerd-shim anymore, leading to the following error when building a "docker only" sysext w/o containerd:
rm: cannot remove 'docker/usr/bin/containerd-shim': No such file or directoryThis PR handles versions below major release 23 separately and only deletes containerd-shim for these versions.
Tested with docker releases 20.10.9, 23.0.0, and 24.0.6.