Make script runnable on Alpine, faster Kubernetes builds #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter does not work on all distros/images. For example, it will fail on the official bash docker image, based on Alpine.
With this change `create_kubernetes_sysext` builds slightly faster.
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two somewhat unrelated changes that you may or may not care for:
/usr/bin/env bash, so that the bakery scripts can be run on Alpine (i.e., inside some Docker containers).How to use
The easiest way to test both changes, is to create a new Kubernetes sysext build.
Testing done
I built the Kubernetes sysext on the official Alpine-based Bash image.