Use only systemd arch identifiers for user parameters #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference in architecture identifiers from upstream binary releases and what systemd expects in the extension metadata or the update manifest easily causes confusion. Recommend the use of the systemd identifiers as they will show up in filenames. Map the identifiers internally and try to do the right thing even if a slighly different identifier was called.
|
We should also add architecture identifiers to the github action, will do it in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference in architecture identifiers from upstream binary releases and what systemd expects in the extension metadata or the update manifest easily causes confusion.
Recommend the use of the systemd identifiers as they will show up in filenames. Map the identifiers internally and try to do the right thing even if a slighly different identifier was called.
The list of systemd identifiers is here https://www.freedesktop.org/software/systemd/man/systemd.unit.html#ConditionArchitecture=
Testing done
Built the wasmtime image with the default arch (x86-64) and for arm64.