Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod_image_util.sh: Temporarily nobble removing unsigned kernel and GRUB #2528

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Dec 13, 2024

Temporarily nobble removing unsigned kernel and GRUB

We would normally remove these for an official build so that the signed versions can be uploaded later. However, we are not doing that signing until we pass the shim review.

How to use

Do a release!

Testing done

I ran shellcheck. We'll do a release to see whether this works now.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update) -- N/A
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc. -- N/A

We would normally remove these for an official build so that the signed
versions can be uploaded later. However, we are not doing that signing
until we pass the shim review.

Signed-off-by: James Le Cuirot <[email protected]>
@chewi chewi requested a review from tormath1 December 13, 2024 10:09
@chewi chewi self-assigned this Dec 13, 2024
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you also backport this to the new Alpha branch please: flatcar-4186 ?

@chewi chewi merged commit 34db26e into main Dec 13, 2024
1 check was waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants