Fixes for flatcar-workon #2080
Merged
Fixes for flatcar-workon #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telling flatcar_workon to work on SDK instead of a board could be
implemented either by passing an empty value for --board flag and
modifying `${FLAGS_board+foo}` to `${FLAGS_board:+foo}` or by adding
the `--host` boolean flag and killing the value of `--board` flag when
`--host` is true.
I went with the latter as it clearly conveys meaning at the call
sites.
We want to possibly update workon packages on SDK, not on the default board.
chewi
approved these changes
Jul 2, 2024
Co-authored-by: James Le Cuirot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_chrootcallsflatcar_workonto get a list of workon packages to rebuild on SDK. But not passing--boardflag toflatcar_workonmeans using default board (amd64-usr), so it really gets a list of packages from the board. But the script failed for me during the sdk_container job, because no board was set up that point.So this PR adds back the
--hostflag toflatcar_workon(which used to be here incros_workon) and makesupdate_chrootpass the new flag to the script.Changes tested as a part of sdk-container job for merged-usr changes.
There are also logs for the failing job, search for
amd64-usr has not been setup yetthere.