changelog: disable DHCP RapidCommit for CloudSigma OEM #2016
Conversation
There was a problem hiding this comment.
Regarding the implementation, as @pothos mentioned, the OEM sysext load might be done too late in the process, thus having systemd already running with RapidCommit=True already.
Can you please try to build the image with locally and make sure the fix works with the built image?
I will try locally with maybe another OEM like qemu that is easier to use too.
Thanks.
| @@ -0,0 +1 @@ | |||
| - Disabled the new DHCP RapidCommit feature which is enabled by default since systemd 255. CloudSigma provides an incompatible implementation which results in cloud-init not being applied as no IP is issued. ([Flatcar#1438](https://github.com/flatcar/Flatcar/issues/1438)) | |||
There was a problem hiding this comment.
Hello, the link in the changelog should be to this PR and the commit message can contain something like:
Fixes:
or
See:
There was a problem hiding this comment.
Thanks, i adapted it. Hopefully the way you meant :).
|
Nice work, just what I needed.. 👍 |
daMupfel
force-pushed
the
disable-dhcp-rapid-commit-for-cloudsigma
branch
from
2b6f609 to
82cced7
Compare
|
Thanks for checking in to this, i will try to build it locally. Have never done it so we will see how it goes :). |
daMupfel
force-pushed
the
disable-dhcp-rapid-commit-for-cloudsigma
branch
2 times, most recently
from
9d55d20 to
be1f827
Compare
|
So i was finally able to test this. While it does work, it only works after a reboot since the network configuration is already loaded at that point. I was not able to figure out how to restart the network service. I tried: But found out later that runcmd is not supported by the coreos-cloudinit implementation. Do you have a suggestion on how i could do that? Regards, David |
|
By the way, what is the plan of moving the next beta to stable? Since it would break for us at that point :) |
daMupfel
force-pushed
the
disable-dhcp-rapid-commit-for-cloudsigma
branch
from
be1f827 to
3975d7e
Compare
|
Okay, so after a bit of looking around in the coreos-cloud i found out that one can also provide network units to cores.units, this doesn't seem to be documented super well. I built a custom image based on the latest beta and applied this change. This does now seem to work as intended. Not sure if i require Regards, David |
|
@ader1990 Hi :), Thank You for the initial review! Is there anything else i can provide to help this PR? |
|
This seems to have missed the stable now. I would like to ask again what there is we can provide to integrate this. We currently require an own image which we would like to stop again. |
Hello @daMupfel sorry for the delay on this PR and thanks for pinging us again. It looks good to me:
|
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10787902516 |
| @@ -0,0 +1 @@ | |||
| - Disabled the new DHCP RapidCommit feature which is enabled by default since systemd 255. CloudSigma provides an incompatible implementation which results in cloud-init not being applied as no IP is issued. See: ([flatcar/scripts#2016](https://github.com/flatcar/scripts/pull/2016)) | |||
There was a problem hiding this comment.
| - Disabled the new DHCP RapidCommit feature which is enabled by default since systemd 255. CloudSigma provides an incompatible implementation which results in cloud-init not being applied as no IP is issued. See: ([flatcar/scripts#2016](https://github.com/flatcar/scripts/pull/2016)) | |
| - CloudSigma: Disabled the new DHCP RapidCommit feature which is enabled by default since systemd 255. CloudSigma provides an incompatible implementation which results in cloud-init not being applied as no IP is issued. See: ([flatcar/scripts#2016](https://github.com/flatcar/scripts/pull/2016)) |
This is specific to CloudSigma so we can precise it.
daMupfel
force-pushed
the
disable-dhcp-rapid-commit-for-cloudsigma
branch
2 times, most recently
from
b02e505 to
5443785
Compare
|
@tormath1 Hi :), no worries. Just wanted to know where we stand here :). Thank you very much for looking into this. I think I adapted the PR as you requested. Regarding the built. I was able to do so by following the documentation (with the container and then the main build and than the specific built). I can test it again if you want. The last time i applied it on the last beta image (which was promoted to stable). Regards, David |
|
@daMupfel I was about to merge this change but I just noticed that there is only one commit that contains the two changes (the actual change and the changelog entry) - you can split this change into two commits, e.g:
or just amend the commit to something like |
daMupfel
force-pushed
the
disable-dhcp-rapid-commit-for-cloudsigma
branch
from
5443785 to
557175b
Compare
|
Hi @tormath1, i split it now up into two commits :). |
|
cherry-picked to:
Thanks for your change! By the way, I noticed there is no documentation for CloudSigma - is there any specific things to know to use Flatcar on this platform? |
|
@tormath1 Thank you very much for taking care of my PR! We don't have any affiliation other than being customers of CloudSigma. At some point, CloudSigma made an effort to support CoreOS, which is where this comes from. At that time, one could select CoreOS as a base image for new VMs. CoreOS then disappeared at some point from the UI. Please take this with a grain of salt since I am only an external observer. |
Disable DHCP RapidCommit for CLoudSigma OEM
This is related to the following issue: flatcar/Flatcar#1438
How to use
Build OEM beta image and upload it to CloudSigma. Create a host with said image.
Testing done
I tested this by manually applying the OEM config to the /oem/cloud-config.yml file and rebooting.
Note: This is my idea how to fix this issue, i am unsure if this is the desired solution and if this is the right branch to merge into as it currently only is an issue on beta builds.