-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-automation/vms: Download vmlinuz file before building VM images #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
pothos
force-pushed
the
kai/pxe-vmlinuz-sign
branch
from
April 18, 2024 15:08
9dcb075
to
33e5490
Compare
pothos
force-pushed
the
kai/pxe-vmlinuz-sign
branch
from
April 18, 2024 15:10
33e5490
to
a061d1e
Compare
pothos
force-pushed
the
kai/pxe-vmlinuz-sign
branch
from
April 19, 2024 02:43
a061d1e
to
5ebde9f
Compare
krnowak
reviewed
Apr 19, 2024
After making flatcar_production_pxe.vmlinuz a symlink to flatcar_production_image.vmlinuz the signature creation didn't work because the target could not be found. As we do with the generic image, download the kernel from bincache, too, before starting the VM image build.
pothos
force-pushed
the
kai/pxe-vmlinuz-sign
branch
from
April 19, 2024 08:34
9275a1f
to
ff2bea0
Compare
krnowak
approved these changes
Apr 19, 2024
pothos
added a commit
that referenced
this pull request
Apr 19, 2024
ci-automation/vms: Download vmlinuz file before building VM images
pothos
added a commit
that referenced
this pull request
Apr 19, 2024
ci-automation/vms: Download vmlinuz file before building VM images
pothos
added a commit
that referenced
this pull request
Apr 19, 2024
ci-automation/vms: Download vmlinuz file before building VM images
pothos
added a commit
that referenced
this pull request
Apr 19, 2024
ci-automation/vms: Download vmlinuz file before building VM images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making flatcar_production_pxe.vmlinuz a symlink to flatcar_production_image.vmlinuz the signature creation didn't work because the target could not be found.
As we do with the generic image, download the kernel from bincache, too, before starting the VM image build.
How to use
Backport
Testing done
Jenkins
Digest/signature files are present now: http://bincache.flatcar-linux.net/images/arm64/9999.9.9+kai-pxe-vmlinuz-sign/flatcar_production_pxe.vmlinuz.DIGESTS