-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_library: Use original qemu image name in qemu script #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move to symlinking to the qemu-uefi image also resulted in the qemu-uefi image being referenced in the qemu-bios and qemu-uefi-secure scripts instead of referencing the image symlinks. Same for the VM name shown in the qemu window title. When generating the qemu scripts, use the original qemu image name and VM name.
krnowak
approved these changes
Apr 17, 2024
pothos
added a commit
that referenced
this pull request
Apr 17, 2024
build_library: Use original qemu image name in qemu script
pothos
added a commit
that referenced
this pull request
Apr 17, 2024
build_library: Use original qemu image name in qemu script
pothos
added a commit
that referenced
this pull request
Apr 17, 2024
build_library: Use original qemu image name in qemu script
pothos
added a commit
that referenced
this pull request
Apr 17, 2024
build_library: Use original qemu image name in qemu script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to symlinking to the qemu-uefi image also resulted in the qemu-uefi image being referenced in the qemu-bios and qemu-uefi-secure scripts instead of referencing the image symlinks. Same for the VM name shown in the qemu window title.
When generating the qemu scripts, use the original qemu image name and VM name.
How to use
Backport
Testing done
GitHub Actions and Jenkins