Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEM: Provide Hetzner Images #1880

Merged
merged 5 commits into from
Apr 17, 2024
Merged

OEM: Provide Hetzner Images #1880

merged 5 commits into from
Apr 17, 2024

Conversation

apricote
Copy link
Contributor

@apricote apricote commented Apr 11, 2024

Provide Hetzner OEM images

Adds build instructions for Hetzner Cloud images.

Pulls in flatcar/init#118 and flatcar/bootengine#94 in a temporary commit, will be removed once they are merged and used in main.

How to use

The process to setup a server using these changes is described here: https://github.com/apricote/flatcar-packer-hcloud/blob/oem-image/README.md

Testing done

I have built the image from this PR (based on an earlier nightly tag) and created a Hetzner Cloud server from it. I have tested the following (custom) functionality:

  • Logging in with SSH Key
  • Correct Hostname
  • Afterburn Metadata File

For the usual Hetzner Cloud OS images, there is some "magic" happening through hc-utils which is not included in this PR. I have not tested any functionality related to this.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@apricote
Copy link
Contributor Author

@tormath1 built a preview image for this PR (9a4705a). It is available here for download: https://bincache.flatcar-linux.net/images/amd64/9999.0.0+hetzner/

I updated my Packer documentation to use this image instead of using a locally built one. New docs + Packer templates are available on a new branch: https://github.com/apricote/flatcar-packer-hcloud/tree/oem-image-prebuilt

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks a lot! Feel free to add a changelog entry in the changes folder: https://github.com/flatcar/scripts/tree/main/changelog/changes

@apricote
Copy link
Contributor Author

  • Updated the commit references for bootengine and coreos-init to their current flatcar-master commits, which include the required changes for this PR. Also incremented their revisions by 1 each
  • Rebased against main and squashed the commits

@apricote apricote marked this pull request as ready for review April 16, 2024 15:15
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution and your tests: it brings a solid foundation to the Flatcar / Hetzner support.

EDIT: I will backport to Alpha

@tormath1 tormath1 merged commit 0d4031a into flatcar:main Apr 17, 2024
@tormath1
Copy link
Contributor

Cherry-picked to:

  • flatcar-3941

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants