-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coreos-base/common-oem-files: Enable flatcar.autologin for OpenStack #1866
Conversation
06263cf
to
c2bb430
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10786051476 |
So far the console in OpenStack (or Brightbox which shares the image) was not usable well until one issues a reboot to add the autologin in the GRUB menu. Add it by default so that one doesn't need this reboot trick.
c2bb430
to
f57a928
Compare
I'm bit baffled by this change. How is it justifiable to enable autologin by default for OpenStack all of a sudden? We were completely surprised by this change when suddenly all our production machine have an open console after a reboot. From a security perspective this is not acceptable. |
Hi @databus23, this change is motivated by two reasons:
That said, if you still want to revert this change here's a Butane / Ignition configuration1: variant: flatcar
version: 1.0.0
kernel_arguments:
should_not_exist:
- flatcar.autologin Lastly, this change is not "sudden" as it was in Beta since May 2024 (https://www.flatcar.org/releases#release-3941.1.0) and we often recommend to users to run a few Beta nodes (when possible) to identify any regression or this kind of changes that might affect a workload. Footnotes |
@databus23 we don't automatically update the oem/grub.cfg on existing systems, only nodes provisioned with a newer image would have this change. How were your production machines aftected after a reboot? |
@jepio You are right. I was mistaken. This did not happen with a simple reboot. In our infrastructure we replace a lot of machines on a constant basis while also performing in-place updates for others. The difference was not immideatly clear to me as usually there is not much different to replacing nodes instead of updating them as long as we don't change the ignition. When reading through the changeling I then jumped to the wrong conclusion that this happening with a simple reboot. |
So far the console in OpenStack (or Brightbox which shares the image) was not usable well until one issues a reboot to add the autologin in the GRUB menu.
Add it by default so that one doesn't need this reboot trick.
How to use
Testing done
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.