Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-base/common-oem-files: Enable flatcar.autologin for OpenStack #1866

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 11, 2024

So far the console in OpenStack (or Brightbox which shares the image) was not usable well until one issues a reboot to add the autologin in the GRUB menu.
Add it by default so that one doesn't need this reboot trick.

How to use

Testing done

# Flatcar GRUB settings

set oem_id="openstack"
set linux_append="flatcar.autologin"
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Copy link

github-actions bot commented Apr 11, 2024

@pothos pothos requested a review from a team April 11, 2024 05:35
So far the console in OpenStack (or Brightbox which shares the image)
was not usable well until one issues a reboot to add the autologin in
the GRUB menu.
Add it by default so that one doesn't need this reboot trick.
@pothos pothos merged commit 265ba81 into main Apr 11, 2024
1 check failed
@databus23
Copy link

I'm bit baffled by this change. How is it justifiable to enable autologin by default for OpenStack all of a sudden? We were completely surprised by this change when suddenly all our production machine have an open console after a reboot. From a security perspective this is not acceptable.

@tormath1 tormath1 deleted the kai/openstack-grub branch September 9, 2024 12:55
@tormath1
Copy link
Contributor

tormath1 commented Sep 9, 2024

I'm bit baffled by this change. How is it justifiable to enable autologin by default for OpenStack all of a sudden? We were completely surprised by this change when suddenly all our production machine have an open console after a reboot. From a security perspective this is not acceptable.

Hi @databus23, this change is motivated by two reasons:

  • the console access might be set from the provider (e.g OpenStack or Brightbox) point of view
  • even without this change, one can still reboot the instance, press e at the grub menu, edit the grub command line manually to append the flatcar.autologin kernel argument, Ctrl+x and result in the same situation

That said, if you still want to revert this change here's a Butane / Ignition configuration1:

variant: flatcar
version: 1.0.0
kernel_arguments:
  should_not_exist:
    - flatcar.autologin

Lastly, this change is not "sudden" as it was in Beta since May 2024 (https://www.flatcar.org/releases#release-3941.1.0) and we often recommend to users to run a few Beta nodes (when possible) to identify any regression or this kind of changes that might affect a workload.

Footnotes

  1. https://www.flatcar.org/docs/latest/installing/cloud/vmware/#disablingenabling-autologin

@jepio
Copy link
Member

jepio commented Sep 10, 2024

I'm bit baffled by this change. How is it justifiable to enable autologin by default for OpenStack all of a sudden? We were completely surprised by this change when suddenly all our production machine have an open console after a reboot. From a security perspective this is not acceptable.

@databus23 we don't automatically update the oem/grub.cfg on existing systems, only nodes provisioned with a newer image would have this change. How were your production machines aftected after a reboot?

@databus23
Copy link

@jepio You are right. I was mistaken. This did not happen with a simple reboot. In our infrastructure we replace a lot of machines on a constant basis while also performing in-place updates for others. The difference was not immideatly clear to me as usually there is not much different to replacing nodes instead of updating them as long as we don't change the ignition. When reading through the changeling I then jumped to the wrong conclusion that this happening with a simple reboot.
I'm sorry for drawing the wrong conclusions initially.

@tormath1 tormath1 mentioned this pull request Oct 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants