Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emulation/actool,acbuild: Remove actool and acbuild #1817

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 2, 2024

Both actool and acbuild upstream are deprecated and probably not in use anymore.
Remove actool from the image and acbuild from the SDK.

Second commit:

Remove ACI image building bits

The ACI OEM container image was used with rkt for GCE. For long time
this has been migrated to systemd-nspawn and now systemd-sysext.
Remove the unused build library code.

How to use

Testing done

In the GitHub Action CI and on Jenkins.

Copy link

github-actions bot commented Apr 2, 2024

@pothos
Copy link
Member Author

pothos commented Apr 2, 2024

Hm, that /update-sdk comment didn't work…

@dongsupark
Copy link
Member

Hm, that /update-sdk comment didn't work…

As far as I know, once you add /update-sdk in a comment or description, you have to refresh any commit, and push to the PR again, so that CI can pick up the event. Without doing that, CI would still skip building SDK.
What I usually do is: git commit --amend --no-edit --date=now && git push --force origin <branchname>

@pothos
Copy link
Member Author

pothos commented Apr 2, 2024

Now that the nightly SDK is built I clicked "rerun" but only for the amd64 job instead of the whole Action job which means that I can't restart the arm64 job now. I guess it's still enough as this is not arch-specific.
Edit: After the first one finished it worked to restart the arm64 sub job.

@pothos pothos requested a review from a team April 2, 2024 12:53
@pothos
Copy link
Member Author

pothos commented Apr 2, 2024

The aci file for the GCE OEM wasn't even using this, it was using tar. I guess we can also clean up this a bit: build_library/oem_aci_util.sh, build_oem_aci and calls from image_to_vm.sh and build_library/vm_image_util.sh to oem_aci

@krnowak
Copy link
Member

krnowak commented Apr 2, 2024

The aci file for the GCE OEM wasn't even using this, it was using tar. I guess we can also clean up this a bit: build_library/oem_aci_util.sh, build_oem_aci and calls from image_to_vm.sh and build_library/vm_image_util.sh to oem_aci

That'd be a nice cleanup. Can be done in follow-up PR if you want to merge this now.

@pothos
Copy link
Member Author

pothos commented Apr 3, 2024

Pushed the cleanup, maybe we should also do a jenkins build

@krnowak
Copy link
Member

krnowak commented Apr 3, 2024

Pushed the cleanup, maybe we should also do a jenkins build

Yes, please.

@pothos
Copy link
Member Author

pothos commented Apr 3, 2024

Jenkins VM image building passed.

An unrelated failure in cl.verity/corruption only on amd64 is strange, though.

     --- FAIL: cl.verity/corruption (1.20s)
             verity.go:107: verity did not prevent reading from a corrupted disk (expected kernel panic)!

@pothos
Copy link
Member Author

pothos commented Apr 3, 2024

An unrelated failure in cl.verity/corruption only on amd64 is strange, though.

Since it passed on GitHub Actions this really seems to unrelated.

@krnowak
Copy link
Member

krnowak commented Apr 3, 2024

An unrelated failure in cl.verity/corruption only on amd64 is strange, though.

Since it passed on GitHub Actions this really seems to unrelated.

Alright, let's merge it, then.

pothos added 2 commits April 3, 2024 16:18
Both actool and acbuild upstream are deprecated and probably not in
use anymore.
Remove actool from the image and acbuild from the SDK.
The ACI OEM container image was used with rkt for GCE. For long time
this has been migrated to systemd-nspawn and now systemd-sysext.
Remove the unused build library code.
@pothos pothos force-pushed the kai/remove-acbuild branch from b6bc3ae to 1513f3a Compare April 3, 2024 07:18
@pothos pothos merged commit 405cff9 into main Apr 3, 2024
1 check failed
@pothos pothos deleted the kai/remove-acbuild branch April 3, 2024 07:19
@pothos
Copy link
Member Author

pothos commented Apr 3, 2024

I wonder if the kola test could be improved to corrupt a bit more and try to flush the cashes again when the first corruption didn't directly trigger the panic.

@pothos
Copy link
Member Author

pothos commented Apr 3, 2024

I've tested the case manually and it helps to overwrite 100 MB instead of 10 MB, will file a mantle PR
Edit: flatcar/mantle#515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants