-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-emulation/actool,acbuild: Remove actool and acbuild #1817
Conversation
97fa73a
to
d61832c
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8534859383 |
Hm, that |
As far as I know, once you add |
Now that the nightly SDK is built I clicked "rerun" but only for the amd64 job instead of the whole Action job which means that I can't restart the arm64 job now. I guess it's still enough as this is not arch-specific. |
The aci file for the GCE OEM wasn't even using this, it was using tar. I guess we can also clean up this a bit: |
That'd be a nice cleanup. Can be done in follow-up PR if you want to merge this now. |
Pushed the cleanup, maybe we should also do a jenkins build |
Yes, please. |
Jenkins VM image building passed. An unrelated failure in
|
Since it passed on GitHub Actions this really seems to unrelated. |
Alright, let's merge it, then. |
Both actool and acbuild upstream are deprecated and probably not in use anymore. Remove actool from the image and acbuild from the SDK.
The ACI OEM container image was used with rkt for GCE. For long time this has been migrated to systemd-nspawn and now systemd-sysext. Remove the unused build library code.
b6bc3ae
to
1513f3a
Compare
I wonder if the kola test could be improved to corrupt a bit more and try to flush the cashes again when the first corruption didn't directly trigger the panic. |
I've tested the case manually and it helps to overwrite 100 MB instead of 10 MB, will file a mantle PR |
Both actool and acbuild upstream are deprecated and probably not in use anymore.
Remove actool from the image and acbuild from the SDK.
Second commit:
Remove ACI image building bits
How to use
Testing done
In the GitHub Action CI and on Jenkins.