sys-kernel/coreos-modules: Enable TPM TIS drivers for arm64 #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
approved these changes
Mar 15, 2024
ader1990
reviewed
Mar 15, 2024
sdk_container/src/third_party/coreos-overlay/sys-kernel/coreos-modules/files/commonconfig-6.6
Outdated
Show resolved
Hide resolved
ader1990
reviewed
Mar 16, 2024
| CONFIG_TCG_TIS_I2C_ATMEL=m | ||
| CONFIG_TCG_TIS_I2C_INFINEON=m | ||
| CONFIG_TCG_TIS_I2C_NUVOTON=m | ||
| CONFIG_TCG_TIS_SPI=m |
There was a problem hiding this comment.
the CI failed
ERROR: sys-kernel/coreos-modules-6.6.21::coreos failed (configure phase):
2024-03-15T19:58:51.4682912Z * Requested options not enabled in build:
2024-03-15T19:58:51.4683239Z * CONFIG_TCG_TIS_SPI
Most likely, because CONFIG_SPI is required for this flag. Maybe we can add I2C and SPI later on, if needed. Adding these two options seem to enable a kernel tree that might bulk up the size.
The arm64 kernel didn't have TPM support for the qemu TPM2 TIS software TPM. This moves the TPM TIS kernel module enablement to the common config of both architectures. Authored-by: Kai Lueke <[email protected]> Signed-off-by: Jeremi Piotrowski <[email protected]>
|
@pothos I've pushed an amended commit that drops the I2C/SPI enablement. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8682904445 |
|
On arm64 the tpm is now correctly detected: |
ader1990
approved these changes
Mar 18, 2024
|
Should we merge this PR to fix the arm64 CI failures? |
dongsupark
approved these changes
Mar 19, 2024
pothos
added a commit
that referenced
this pull request
Apr 15, 2024
sys-kernel/coreos-modules: Enable TPM TIS drivers for arm64
|
Cherry-picked for 3913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arm64 kernel didn't have TPM support for the qemu TPM2 TIS software TPM.
This moves the TPM TIS kernel module enablement to the common config of both architectures. In addition it enables the SPI and I2C drivers.
How to use
This should make the clevis test work on arm64 as it does on amd64.
Note that there is still a service error message on first boot which causes kola to mark the test failed.
Testing done
TODO: When the build succeeds we could try the (fixed) kola test or do a manual test