Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay sys-kernel/coreos-modules: Enable mmc_block as a module #1510

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

pysen
Copy link
Contributor

@pysen pysen commented Dec 19, 2023

overlay sys-kernel/coreos-modules: Enable mmc_block as a module

Enables the mmc_block driver reported missing in flatcar/Flatcar#1300

How to use

  • Install flatcar to hardware with eMMC drive slot (will be tested once built).

Testing done

  • None yet

@pothos
Copy link
Member

pothos commented Dec 19, 2023

I've tested it with the 6.1 kernel and it doesn't seem to hurt adding it explicitly but I wonder why the module was not found in your case - maybe in the initrd it's missing?
Edit: Yes, missing in the initrd is the problem we need to solve here

Copy link

github-actions bot commented Dec 19, 2023

@pothos
Copy link
Member

pothos commented Dec 19, 2023

We need to add mmc_block in the bootengine repo https://github.com/flatcar/bootengine/blob/flatcar-master/update-bootengine#L37 and then update the ebuild file ref here in sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild

@pothos
Copy link
Member

pothos commented Dec 19, 2023

We need to add mmc_block in the bootengine repo https://github.com/flatcar/bootengine/blob/flatcar-master/update-bootengine#L37 and then update the ebuild file ref here in sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild

Created a PR here: flatcar/bootengine#81

@pothos
Copy link
Member

pothos commented Dec 19, 2023

Can you make this change?

diff --git a/sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild b/sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild
index ab88903330..4806ea0d1f 100644
--- a/sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild
+++ b/sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild
@@ -10,7 +10,7 @@ CROS_WORKON_REPO="https://github.com"
 if [[ "${PV}" == 9999 ]]; then
        KEYWORDS="~amd64 ~arm ~arm64 ~x86"
 else
-       CROS_WORKON_COMMIT="31d24b87717e6ee3b2970af5926a481d6bbff933" # flatcar-master
+       CROS_WORKON_COMMIT="72c39f0963f31e5dcbb262213a453916836e9099" # TODO: flatcar-master
        KEYWORDS="amd64 arm arm64 x86"
 fi

@pothos
Copy link
Member

pothos commented Dec 19, 2023

Tested locally and it works

@pothos pothos merged commit 41780a6 into flatcar:main Dec 20, 2023
@pothos
Copy link
Member

pothos commented Dec 20, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants