-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-apps/ignition: Use new upstream patch #1403
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
November 20, 2023 19:42
bf4ddd3
to
12ae311
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
November 21, 2023 10:41
12ae311
to
e49954f
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10791826588 |
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
November 22, 2023 12:24
cf70f17
to
ccb2dd7
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
November 22, 2023 16:37
ccb2dd7
to
14c858f
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
December 15, 2023 16:59
14c858f
to
ee8b4b8
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
December 15, 2023 17:06
ee8b4b8
to
c549ad3
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
December 18, 2023 11:48
c549ad3
to
3d8e145
Compare
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
December 18, 2023 17:19
3d8e145
to
5b82105
Compare
pothos
added a commit
to flatcar/bootengine
that referenced
this pull request
Dec 18, 2023
Partx is already present, but not explicitly mentioned. We can use it instead of partprobe when adapting the Ignition patch in flatcar/scripts#1403
2 tasks
pothos
added a commit
to flatcar/bootengine
that referenced
this pull request
May 6, 2024
Partx is already present, but not explicitly mentioned. We can use it instead of partprobe when adapting the Ignition patch in flatcar/scripts#1403
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
May 6, 2024 13:37
dd68a06
to
c74d45e
Compare
This pulls in flatcar/bootengine#80 to use partx instead of partprobe.
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
May 7, 2024 04:36
c74d45e
to
104031b
Compare
The patch was reworked to use partx which already is in the initrd and to have safety checks for disks in use.
pothos
force-pushed
the
kai/ignition-new-patch
branch
from
May 7, 2024 06:23
104031b
to
d2694e8
Compare
This has been merged upstream and it will be pulled in the next Ignition upgrade. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch was reworked to use partx which already is in the initrd and to have safety checks for disks in use.
How to use
Wait for the upstream PR to be merged. Then resync and drop partprobe from bootengine (flatcar/bootengine#80) and update the commit here to the git merge commit ref.
Testing done
Tested three cases, the overwriting of USR-A was detected and an error thrown, the other two changes passed without problem because the USR-B is unused and can be overwritten and the new partition is also ok to add (confirmed with
lsblk
that the kernel has the updated values thanks to partx):changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.