Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenStack image for Brightbox #1391

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Use OpenStack image for Brightbox #1391

merged 2 commits into from
Nov 16, 2023

Conversation

pothos
Copy link
Member

@pothos pothos commented Nov 14, 2023

  • Use OpenStack image for Brightbox

    The special Brightbox image uses the OpenStack userdata in Ignition but
    lacked Afterburn usage. It actually works to use the OpenStack image and
    directly which also enables Afterburn, thus we can drop the special
    image.
    Don't build a special image for Brightbox but recommend to use OpenStack
    images directly. A symlink is added to help with the download of
    hardcoded user scripts.

  • ci-automation/vms: Provide OpenStack image without external compression

    For Brightbox we can use the OpenStack image but the import only works
    with unpacked images. After we enabled internal qcow2 compression the
    .gz or .bz2 external compression doesn't provide any benefits and makes
    the import more complicated.
    Provide the OpenStack image without external compression in addition.
    The other files are kept for now but we could also delete them if we
    announce this in advance.

How to use

Testing done

The openstack image was tested on brightbox by @tormath1

Checked bincache results for jenkins job and now we have a symlink but regular digest files.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

For Brightbox we can use the OpenStack image but the import only works
with unpacked images. After we enabled internal qcow2 compression the
.gz or .bz2 external compression doesn't provide any benefits and makes
the import more complicated.
Provide the OpenStack image without external compression in addition.
The other files are kept for now but we could also delete them if we
announce this in advance.
ci-automation/vms.sh Outdated Show resolved Hide resolved
The special Brightbox image uses the OpenStack userdata in Ignition but
lacked Afterburn usage. It actually works to use the OpenStack image and
directly which also enables Afterburn, thus we can drop the special
image.
Don't build a special image for Brightbox but recommend to use OpenStack
images directly. A symlink is added to help with the download of
hardcoded user scripts.
@tormath1
Copy link
Contributor

Works fine:

$ BRIGHTBOX_IMAGE_ID=$(ore brightbox create-image --name flatcar-main --url http://bincache.flatcar-linux.net/images/amd64/9999.9.9+brightbox/flatcar_production_openstack_image.img)
$ kola --parallel 1 --platform brightbox run cl.basic
--- PASS: cl.basic (81.42s)
$ systemctl status -o cat coreos-metadata-sshkeys@core
Starting [email protected] - Flatcar Metadata Agent (SSH Keys)...
Nov 15 17:29:23.178 WARN failed to locate config-drive, using the metadata service API instead
Nov 15 17:29:23.232 INFO Fetching http://169.254.169.254/latest/meta-data/public-keys: Attempt #1
Nov 15 17:29:23.268 INFO Fetch successful
Nov 15 17:29:23.268 INFO Fetching http://169.254.169.254/latest/meta-data/public-keys/0/openssh-key: Attempt #1
Nov 15 17:29:23.301 INFO Fetch successful
wrote ssh authorized keys file for user: core
Updated "/home/core/.ssh/authorized_keys"
Finished [email protected] - Flatcar Metadata Agent (SSH Keys).
$ journalctl --identifier ignition -o cat
...
GET http://169.254.169.254/openstack/latest/user_data: attempt #2
GET result: OK
parsing config with SHA512: 0d64ee310f4fa697c7df9fbd56e532c2ebd77669f173c7a7caedb2db70da5b14d2e2358e1cb61b00b1c2285711c490d0e3d42b9a52f3f8d8bd439493d2b66f44
fetch: fetch complete
fetch: fetch passed
Ignition finished successfully

Copy link

github-actions bot commented Nov 15, 2023

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pothos
Copy link
Member Author

pothos commented Nov 16, 2023

Because this relies on the openstack oem rework I don't think we can easily backport it fully but we could, e.g., backport the uncompressed OpenStack image to have some consistency.

@pothos pothos merged commit bd36d82 into main Nov 16, 2023
1 check failed
@pothos pothos deleted the kai/brightbox branch November 16, 2023 17:31
pothos added a commit that referenced this pull request Nov 16, 2023
Use OpenStack image for Brightbox
@pothos
Copy link
Member Author

pothos commented Nov 16, 2023

Backport done down to 3510+3033 (LTS and old-LTS) by not removing the full ebuild but only the brightbox flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants