build_library/grub_install: Try mounting ESP directory in a loop #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently successful `[[ -b "${LOOP_DEV}p1" ]]` check is not enough -
the mount can still fail. So instead of doing those checks, try
mounting and reprobing in the loop with some small exponential
backoffs.
jepio
approved these changes
Oct 13, 2023
pothos
reviewed
Oct 13, 2023
| fi | ||
| warn "loopback device node ${LOOP_DEV}p1 still missing, reprobing..." | ||
| sudo blockdev --rereadpt "${LOOP_DEV}" |
There was a problem hiding this comment.
If you want to be sure that it succeeds, use sudo partprobe "${LOOP_DEV}" because blockdev can fail with BLKRRPART: Device or resource busy
There was a problem hiding this comment.
(Had the same problem with Ignition creating partitions on the boot device)
There was a problem hiding this comment.
We can revisit this, if issues with grub install script crop up again.
krnowak
added a commit
that referenced
this pull request
Oct 18, 2023
build_library/grub_install: Try mounting ESP directory in a loop
krnowak
added a commit
that referenced
this pull request
Oct 18, 2023
build_library/grub_install: Try mounting ESP directory in a loop
krnowak
added a commit
that referenced
this pull request
Oct 18, 2023
build_library/grub_install: Try mounting ESP directory in a loop
krnowak
added a commit
that referenced
this pull request
Oct 18, 2023
build_library/grub_install: Try mounting ESP directory in a loop
|
Backported to 3033, 3510, 3602 and 3745. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6560445310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently successful
[[ -b "${LOOP_DEV}p1" ]]check is not enough - the mount can still fail. So instead of doing those checks, try mounting and reprobing in the loop with some small exponential backoffs.Tested in http://jenkins.infra.kinvolk.io:8080/job/container/job/image/3905/