Fix garbled output in image changes reports #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First issue is that on Jenkins, the beginning of the output seems to be eaten, leaving us only the final part of the reports. This looks like an issue stemming from redirecting stdout to stdout with ">/dev/stdout". Special case the stdout by not redirecting anything in such case. Second issue is that errors printed by the tools we use for generating the reports go to stderr, so they don't show in the report. So redirect their stderr to stdout, so the possible errors are visible in the report file too. We do not want to redirect the stderr of the print_image_reports function, because that would also capture debugging stuff from "set -x" that GitHub Actions are using.
There's a bug in show-changes script where it defaults to values with single quotes in them. So the default scripts directory is not "scripts" but "'scripts'". This will be fixed in show-scripts, but for now work it around here by explicitly defining the directories.
krnowak
had a problem deploying
to
development
GitHub Actions
Failure
pothos
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 issues needed fixing:
Fix tested in http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/2999/console