oem: port digitalocean, equinix metal (packet) and openstack #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
had a problem deploying
to
development
GitHub Actions
Error
I think it's a good idea to clean up unused/untested OEM setups, best would be in a follow-up and not linked to this PR, or? |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6337223529 |
pothos
reviewed
Sep 27, 2023
| KEYWORDS="amd64 arm64" | ||
| IUSE="" | ||
|
|
||
| OEM_NAME="Packet" |
There was a problem hiding this comment.
We can rename this variable, it's used in the shell prompt message but otherwise I think it's not relevant
pothos
reviewed
Sep 27, 2023
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
c52bd33 to
831375f
Compare
tormath1
had a problem deploying
to
development
GitHub Actions
Error
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
831375f to
55821de
Compare
tormath1
had a problem deploying
to
development
GitHub Actions
Error
Ok, anyway it was making the CI failing because it was trying to build the image for this vendor too. I cherry-picked the commit and pushed to another branch to do the removal in a follow-up PR. |
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
55821de to
88f915d
Compare
tormath1
had a problem deploying
to
development
GitHub Actions
Error
tormath1
force-pushed
the
tormath1/oem-openstack
branch
4 times, most recently
from
8754e43 to
e72942e
Compare
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
e72942e to
149b0a8
Compare
pothos
reviewed
Oct 2, 2023
Comment on lines
2
to
18
| ConditionKernelCommandLine=|flatcar.oem.id=ec2 | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=ec2 | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=azure | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=azure | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=digitalocean | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=digitalocean | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=gce | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=gce | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=openstack | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=openstack | ||
|
|
||
| ConditionKernelCommandLine=|flatcar.oem.id=packet | ||
| ConditionKernelCommandLine=|flatcar.coreos.id=packet |
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
149b0a8 to
cb25663
Compare
pothos
reviewed
Oct 4, 2023
pothos
reviewed
Oct 5, 2023
sdk_container/src/third_party/coreos-overlay/coreos-base/misc-files/files/oems/packet
Show resolved
Hide resolved
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
QEMU is not supported by Afterburn, let's add an extra-check to be sure that the service will not run on this platform. On cloud-init provisioned system, units are wrote in '/etc' after a certain moment, if a unit takes precedence on one in '/usr' the one in '/usr' would have certainly already started. That's the case for 'coreos-metadata.service' (wrote in '/etc' by cloud-init but already available in '/usr'). ``` $ journalctl -u coreos-metadata.service Sep 29 07:37:57 localhost systemd[1]: Starting coreos-metadata.service - Flatcar Metadata Agent... Sep 29 07:37:57 localhost coreos-metadata[1266]: Error: failed to run Sep 29 07:37:57 localhost coreos-metadata[1266]: Caused by: Sep 29 07:37:57 localhost coreos-metadata[1266]: 0: fetching metadata from provider Sep 29 07:37:57 localhost coreos-metadata[1266]: 1: unknown provider 'qemu' Sep 29 07:37:57 localhost systemd[1]: coreos-metadata.service: Main process exited, code=exited, status=1/FAILURE Sep 29 07:37:57 localhost systemd[1]: coreos-metadata.service: Failed with result 'exit-code'. Sep 29 07:37:57 localhost systemd[1]: Failed to start coreos-metadata.service - Flatcar Metadata Agent. Sep 29 07:37:58 core1 systemd[1]: coreos-metadata.service: Scheduled restart job, restart counter is at 1. Sep 29 07:37:58 core1 systemd[1]: Stopped coreos-metadata.service - QEMU metadata agent. Sep 29 07:37:58 core1 systemd[1]: Starting coreos-metadata.service - QEMU metadata agent... Sep 29 07:37:58 core1 systemd[1]: coreos-metadata.service: Deactivated successfully. Sep 29 07:37:58 core1 systemd[1]: Finished coreos-metadata.service - QEMU metadata agent. ``` Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/oem-openstack
branch
from
133a855 to
bafe49f
Compare
pothos
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These OEM do not ship any software, they only use systemd services (
[email protected]andpacket-phone-home.service).Need:
Closes:
I don't think a changelog entry is required as the sysext images are "empty".