-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate reports for OEM and base sysext images, allow reports against last nightly #1169
Conversation
Would be good to have a Jenkins and GA run for that |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6970117426 |
For sure. I was waiting for the flatcar-build-scripts stuff to go in. Will kick off them soon. |
dfdd83a
to
cfee224
Compare
Jenkins again:
GH is running. |
6d389e8
to
9bbb7da
Compare
aaa1c1c
to
d990148
Compare
505f733
to
165d639
Compare
Seems to be working in general. OEM package reports are not working yet, because there are no such reports on bincache - this PR introduces building such reports. On github the OEM reports are useless, because we build only the qemu images, so azure, vmware, ami and others only have error messages about missing files. Jenkins: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2709/cldsv/ |
165d639
to
6db8859
Compare
94cbb4b
to
8426698
Compare
It shows changes also in OEM images and these are built in vms step.
For now we don't have a single place where we could learn about which OEMs with a sysext image gets built for certain architecture. So add it for now to the coreos-base/common-oem-files package. Missing architecture info for an OEM that gets built only in a certain arch is not going to be fatal for the image changes job - we will just get a report for this OEM with messages about failures to download some files.
This is to limit the amount of reports consisting purely of failures, because some files were missing. And those files will be missing, because an OEM might not even have any image for certain arches (like digitalocean has no arm64 images).
This avoid messing with quotes.
Instead of depending on default value of build_image's base_sysext parameter, create a file that explicitly lists which base sysexts will be built for each architecture. The file can be sourced by other scripts that need this kind of information. Currently, image.sh and image_changes.sh use this file.
Image changes job needs a list of OEMIDs that are built for a specific architecture. Similar information already existed in the coreos-base/common-oem-files ebuild, so factor it out to a separate file, so the image changes job does not need to source the entire ebuild (or process it in other way), but rather source the smaller file.
Please read the comment at the top of the coreos-base/common-oem-files ebuild for details.
EAPI needs to be defined within first 24 lines, so the description would push the definition too much down as it needs to happen after possible declaration of EAPI as local for the source case.
Assignment of EAPI must be the first non-comment, non-blank line in the ebuild, otherwise portage masks it as corrupted.
show-fixed-kernel-cves.py script from flatcar-build-scripts requires this package: Traceback (most recent call last): File "/home/runner/actions-runner/_work/scripts/scripts/flatcar-build-scripts/show-fixed-kernel-cves.py", line 29, in <module> from packaging import version ModuleNotFoundError: No module named 'packaging'
No need in making it arch-specific.
225ad53
to
3d4ddf8
Compare
I have split |
I decided to not do the backporting as the advantages of doing it are rather slim - once a version hits a LTS/stable/beta/alpha channel, the image changes job is of limited use - almost nothing changes there comparing to the previous nightly in the channel. The important changes (like kernel version and kernel config changes and the like) are still printed. Instead I went with a cut-off version of 3795 in jenkins os to decide whether to kick off two image-changes jobs or just one. |
CI has passed. So for versions <3795, we will do the old stuff (image changes against last release, done after the image job, no changes in base sysexts and OEM sysexts), while for newer versions the new stuff (image changes against last release and last nightly, done after vms job, display changes in base sysexts and OEM sysexts). |
Needs flatcar/flatcar-build-scripts#149 first. Tested locally.Needs flatcar/flatcar-build-scripts#153 now.This does mostly two things: