Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sysext image for VMware OEM #1146

Merged
merged 30 commits into from
Sep 25, 2023
Merged

Sysext image for VMware OEM #1146

merged 30 commits into from
Sep 25, 2023

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Sep 15, 2023 •
edited
Loading

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages/4451/cldsv/

  • net-libs/rpcsvc-proto: [PROD] [DEV]

  • dev-libs/xmlsec: [VMWARE]

    • new package, at 1.3.1
    • a dependency of app-emulation/open-vm-tools

  • dev-libs/libmspack: [VMWARE]

    • still at 0.10.1_alpha-r1
    • moved from overlay to portage-stable and added to automation
      • Flatcar modifications were dropped, as they were about putting stuff in to /oem
    • EAPI 8
    • dropped static-libs USE flag

  • sys-fs/fuse-common: [VMWARE]

    • new package, at 3.10.4
    • a dependency of sys-fs/fuse

  • sys-fs/fuse: [VMWARE]

    • new package, at 3.16.1
    • a dependency of app-emulation/vmware
    • pulling in an unstable version, as it fixes an issue with cross-compilation

  • dev-libs/libdnet: [VMWARE]

  • app-emulation/open-vm-tools: [VMWARE]

    • from 12.3.0 to 12.3.0-r1
    • synced with Gentoo, dropping all the OEM modifications
    • all the modifications are planned to be upstreamed to Gentoo
    • enabled vmhgfs-fuse
    • enabled installation of udev rules
    • enabled vgauth
    • enabled pam
    • added a user patch to tell the configure script to use kernel version from sys-kernel/coreos-kernel
    • containerinfo is still disabled, will work on enabling it later

--

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@krnowak krnowak force-pushed the krnowak/vmware-sysext branch from f6bc96e to adf2794 Compare September 15, 2023 14:22
@krnowak krnowak force-pushed the krnowak/vmware-sysext branch from adf2794 to 5bcd413 Compare September 18, 2023 13:32
@krnowak krnowak force-pushed the krnowak/vmware-sysext branch from 5bcd413 to 1e0bbee Compare September 18, 2023 14:32
@krnowak krnowak force-pushed the krnowak/vmware-sysext branch from 1e0bbee to 23039d9 Compare September 20, 2023 07:17
@krnowak
build_library/vm_image_util: Opt VMware OEM into sysext images
fa3dc6b
@krnowak
coreos-base/common-oem-files: Add VMware OEM common files
6f2189e 
This will replace files in coreos-base/oem-vmware package.
@krnowak
app-emulation/open-vm-tools: Sync with Gentoo
b1e69f4 
It's from Gentoo commit ecc674a080e039b5db316f4f8258315c1936801a.
@krnowak
overlay app-emulation/open-vm-tools: Drop old ebuild, bump version
fa2f210
@krnowak
overlay app-emulation/open-vm-tools: Apply Flatcar modifications
0336d57 
None of these modifications are actually specific to Flatcar. This is
something we will want to upstream to Gentoo.
@krnowak
coreos/user-patches: Add a patch for app-emulation/open-vm-tools
67a2aa9
@krnowak
overlay profiles: Update USE flags for app-emulation/open-vm-tools
cc40a00
@krnowak
overlay coreos-base/oem-vmware: Update to be sysext-ready
90b74e2 
Ignition files are not necessary any more. Grub config file and
oem-releas file are now provided by the coreos-base/oem-common-files
package.

We install drop-in files for systemd units instead of providing our
own copies. This is where we set up PrivateTmp option and create
symlinks for /etc.

There's also manglefs.sh script, that will be executed by the
build_sysext utility. It drops unnecessary stuff like translations,
debugging symbols and development files.
@krnowak
overlay coreos-base/misc-files: Add a list of old VMware OEM image files
ccae9d4 
This list will be used by bootengine to clean up old installation of
VMware OEM software before installing a sysext.
@krnowak
overlay dev-libs/libdnet: Move to portage-stable
c6c2f83
@krnowak
dev-libs/libdnet: Sync with Gentoo
63cca7c 
It's from Gentoo commit 7d00351296070d4b6cea6913fab62b96819abddb.
@krnowak
.github: Add dev-libs/libdnet to package automation
a89adcd
@krnowak
overlay profiles: Add accept keywords for dev-libs/libdnet
618e11d
@krnowak
sys-fs/fuse: Add from Gentoo
481b0e0 
It's from Gentoo commit ba10b3c5f0eec6233e4dfbfa65db40253e7fdd7d.
@krnowak
.github: Add sys-fs/fuse to package automation
88ff21b
@krnowak
overlay profiles: Do not install suid binaries from sys-fs/fuse
03d9d32
@krnowak
overlay profiles: Add accept keywords for sys-fs/fuse
64dbcc6
@krnowak
sys-fs/fuse-common: Add from Gentoo
19a3cdd 
It's from Gentoo commit 86f1cf927f6a27a19482e1eb25430e47d5f58ff7.
@krnowak
.github: Add sys-fs/fuse-common to package automation
d33d42f
@krnowak
overlay dev-libs/libmspack: Move to portage-stable
dda041a
@krnowak krnowak force-pushed the krnowak/vmware-sysext branch from 23039d9 to e7de80a Compare September 20, 2023 08:04
@krnowak krnowak marked this pull request as ready for review September 20, 2023 08:11
@krnowak krnowak requested review from a team and pothos September 20, 2023 08:11
@krnowak
Copy link
Member Author

krnowak commented Sep 20, 2023

CI passed.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6249436756

@pothos
Copy link
Member

pothos commented Sep 20, 2023 •
edited
Loading

Thanks, it looks good and I will try to test by booting and looking around if that wasn't done yet.
We should test the migration as well by updating from an old instance twice and check that all is ok (sudo ./flatcar-update -E flatcar_test_update-oem-vmware.gz -P flatcar_test_update.gz -V 1.2.3 -D -A).
Done; all looks good!

pothos
pothos approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@krnowak krnowak merged commit c593d76 into main Sep 25, 2023
1 check failed
@krnowak krnowak deleted the krnowak/vmware-sysext branch September 25, 2023 12:51
This was referenced Sep 25, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pothos pothos pothos approved these changes

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krnowak @pothos @dongsupark