-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in flatcar/init and bootengine changes to ignore mana VF in networkd #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs a rebase. EDIT: changelog is already there. |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6196727380 |
dongsupark
reviewed
Sep 12, 2023
jepio
changed the title
Pull in flatcar/init change to ignore mana VF in networkd
Pull in flatcar/init and bootengine changes to ignore mana VF in networkd
Sep 15, 2023
The flatcar/init commits includes a change to the azure sriov config file that excludes devices managed by the mana driver from networkd management, just like mlx4 and mlx5 devices. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
azure-mana-vf
branch
from
September 15, 2023 09:29
872755f
to
1329ae4
Compare
The flatcar/bootengine commit includes a change to the azure sriov config file that excludes devices managed by the mana driver from networkd management, just like mlx4 and mlx5 devices. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
azure-mana-vf
branch
from
September 15, 2023 09:33
1329ae4
to
eb5db9b
Compare
dongsupark
approved these changes
Sep 15, 2023
Running testing on Azure to ensure no regressions: |
jepio
added a commit
that referenced
this pull request
Sep 18, 2023
Pull in flatcar/init and bootengine changes to ignore mana VF in networkd
jepio
added a commit
that referenced
this pull request
Sep 18, 2023
Pull in flatcar/init and bootengine changes to ignore mana VF in networkd
jepio
added a commit
that referenced
this pull request
Sep 18, 2023
Pull in flatcar/init and bootengine changes to ignore mana VF in networkd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in flatcar/init change to ignore mana VF in networkd
Add mana driver to the list of drivers ignored by networkd on Azure. Pulls in:
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
Will test in jenkins to see that it doesn't break anything in existing instances on azure, but otherwise we don't have access to mana instances yet.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.