Node version update #878
Open
Node version update #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-run npm install with node 22 to check actual outdated deps
to update webpack and babel
updated react scripts to the latest version for compatibility with nodejs 22
increase node version in workflow and dockerfile
after new dep resolution, MUI got a minor version bumb
node version 22 & newer react-script version
Minor version bump of MUI deprecated the old prop name
executed prettier to format code
fixed ts version to 4.4.x due to compatibility issues until eslint upgrade happens See #issue_number
upgraded sb to 7 to use webpack 5
ErvinRacz
force-pushed
the
node-version-update
branch
from
662b072 to
21d0612
Compare
querystrings pkgs deprecated and replaced with native func
MUI 4 not compat with React 18 and some react scripts prefer react v18 with webpack 5
react-refresh didn't want to dedupe, and would cause dev runtime issues => override
With MUI 5, the theme and style engine became stricter, therefore comps needed to be wrapped with the theme provider in some cases
MUI5 has a different styling engine, therefore the snaposhots have changed
the default config for some components have changed, so standard variant had to be specified
ErvinRacz
force-pushed
the
node-version-update
branch
from
ae4b4e9 to
aabfe8a
Compare
the style had to be brough back with the previous commits to the original state, so snapshots have changed again
|
CI starts to look good: we just need to:
|
Great! I will go with the first option and add a couple of more tests since the threshold is almost met. |
satisfy test coverage
There was a problem hiding this comment.
Copilot reviewed 129 out of 144 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Dockerfile: Language not supported
- frontend/package.json: Language not supported
- frontend/public/index.html: Language not supported
- frontend/src/tests/Common/snapshots/EmptyContent.spec.js.snap: Language not supported
- frontend/src/tests/Common/snapshots/ListHeader.spec.js.snap: Language not supported
- frontend/src/tests/Common/snapshots/ListSearch.spec.js.snap: Language not supported
- frontend/src/tests/Common/snapshots/SectionHeader.spec.js.snap: Language not supported
- .github/workflows/frontend.yml: Evaluated as low risk
- frontend/src/components/Activity/ActivityContainer.stories.tsx: Evaluated as low risk
- frontend/src/api/API.ts: Evaluated as low risk
- frontend/src/tests/Common/SectionHeader.spec.js: Evaluated as low risk
- frontend/src/tests/Common/PackagesList.spec.js: Evaluated as low risk
- frontend/src/tests/Common/ListHeader.spec.js: Evaluated as low risk
- frontend/src/tests/Common/ModalButton.spec.js: Evaluated as low risk
- frontend/.storybook/preview.js: Evaluated as low risk
Comments suppressed due to low confidence (1)
frontend/src/TestHelpers/theme.ts:11
- [nitpick] The change from green['500'] to green['800'] might affect the UI. Verify if this change was intended.
main: green['800'],
lodash required a newer TS version, but the eslint-config repo was archived and fixed on an older eslint version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node version
Summary
This PR updates the Node.js version used in GitHub workflows to Node.js 22 as Node.js 16 is now outdated. This required updates to several dependencies and tools to maintain compatibility and ensure smooth project functionality.
Changes
Node.js Upgrade:
Updated GitHub workflow configuration to use Node.js 22.
Re-generated package-lock.json with Node.js 22.
Upgraded react-scripts to 5.0.1 to align with the new Node.js version.
Cascading Updates:
Addressed compatibility issues with certain MUI components, TypeScript, and Storybook:
-- Upgraded MUI4 to MUI5
-- Upgraded Storybook 6 to Storybook 7
Adjusted testing config to ensure compatibility with the updated dependencies.
Upgraded from React 17 to 18.
Updated several other dependencies too (refer to the full list in the package.json).
With all these, detected vulnerabilities have been reduced from 177 vulnerabilities (6 low, 112 moderate, 50 high, 9 critical)
to 12 vulnerabilities (5 moderate, 7 high)
How to Use
The project should function exactly as it did previously with no noticeable changes in functionality.
Testing
Initial testing has been conducted, and the project builds successfully with Node.js 22.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.