Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix tipo of helm repo address #671

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

H0lySh1t
Copy link
Contributor

Docs: remove trailing slash of helm repo address

Remove trailing slash of helm repo address in the documentation, so the command won't fail.

How to use

Execute the helm repo add command

Testing done

Tested on Ubuntu 22.04.2 LTS with helm3 v3.10.1

Original:

~$ helm repo add nebraska https://kinvolk.github.io/nebraska/
Error: looks like "https://kinvolk.github.io/nebraska/" is not a valid chart repository or cannot be reached: failed to fetch https://kinvolk.github.io/nebraska/index.yaml : 404 Not Found

Fixed:

~$ helm repo add nebraska https://flatcar.github.io/nebraska
"nebraska" has been added to your repositories
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@H0lySh1t H0lySh1t mentioned this pull request Nov 10, 2023
@tormath1
Copy link
Contributor

Hello @H0lySh1t thanks for your contribution. I think the main issue, as shown in your bash snippets, is the renaming from kinvolk to flatcar (and not the trailing slash):

- $ helm repo add nebraska https://kinvolk.github.io/nebraska
+ $ helm repo add nebraska https://flatcar.github.io/nebraska

@H0lySh1t
Copy link
Contributor Author

🤦‍♂️ sorry

@tormath1
Copy link
Contributor

@H0lySh1t 👋 do you want to push a fix to merge this contribution? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants