Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm-chart): Add ability to deploy extra manifests #659

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

mkilchhofer
Copy link
Contributor

Add ability to deploy extra manifests within the helm chart

It is common now that helm charts offer the ability to deploy custom resources along the application. It is especially useful for managing Secrets (eg. via external-secrets.io / Secrets Store CSI Driver) or deploying more granular NetworkPolicy (eg. CiliumNetworkPolicy).

Charts in the community that supports this:

  • all Argoproj charts (Argo CD, Argo workflows, ...)
  • grafana charts (Grafana, Promtail, Loki, etc.)
  • most Bitnami charts
  • VictoriaMetrics charts
  • prometheus-community charts

How to use

See example in values.yaml:

extraObjects:
  - apiVersion: external-secrets.io/v1beta1
    kind: ExternalSecret
    metadata:
      name: my-external-secret
      namespace: '{{ .Release.Namespace }}'
    spec:
      secretStoreRef:
        kind: ClusterSecretStore
        name: my-secret-store
      target:
        name: my-kubernetes-secret
      data:
        - secretKey: secretKey
          remoteRef:
            key: /path/to/my-secret

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@mkilchhofer mkilchhofer force-pushed the feature/helm-chart_extra-manifests branch from 4d8c039 to 5a5b6e3 Compare July 12, 2023 11:07
@joaquimrocha
Copy link
Collaborator

@tormath1 , can you take a look?

@pothos
Copy link
Member

pothos commented Jul 24, 2023

Sorry for the review delay, we'll try to assign someone in tomorrow's planning call flatcar/Flatcar#1103

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - seen this on other projects. Thanks for the addition!

@tormath1 tormath1 merged commit 9151240 into flatcar:main Jul 26, 2023
@mkilchhofer mkilchhofer deleted the feature/helm-chart_extra-manifests branch December 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants