vbatts/backend update #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting was spitting many things that I believe were solved in newer versions Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
vbatts/backend_update
branch
from
ea25bc7 to
690baa5
Compare
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
vbatts/backend_update
branch
from
fd8bbf5 to
befc1d0
Compare
|
ok. Ready for review. |
yolossn
requested changes
Mar 19, 2023
Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
vbatts/backend_update
branch
from
762cd8e to
59b35b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linters and golang updates
fix inconsistencies in reported linting, and differences in the versions of golang used.
I'm testing this locally with
go1.19.7now, since thebackend/go.modsays go1.19.Though the github workflow was using go1.17 currently, but now is also go1.19.
This also aligns an issue I found where I saw errors by running
make(i.e.make all) locally, but did not see them inmake cilocally or on the github action. Now that is cleaned up.Testing done
cd backend make all ciand now the github actions output
Closes: #638