Add API integration tests #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolossn
force-pushed
the
api_test
branch
2 times, most recently
from
e6cc27a to
325ec6f
Compare
This patch adds the docker compose file that will used for the e2e tests Signed-off-by: Santhosh Nagaraj S <[email protected]>
Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to applications Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to groups Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to channels Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for config endpoint Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to instance Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to activity Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for the endpoints related to packages Signed-off-by: Santhosh Nagaraj S <[email protected]>
yolossn
force-pushed
the
api_test
branch
4 times, most recently
from
382d3bb to
47ea740
Compare
This patch adds the e2e tests for the endpoints related to instance stats Signed-off-by: Santhosh Nagaraj S <[email protected]>
This patch adds the e2e tests for omaha endpoint Signed-off-by: Santhosh Nagaraj S <[email protected]>
illume
reviewed
Jan 10, 2022
illume
reviewed
Jan 10, 2022
|
|
||
| assert.Equal(t, len(timelineDB), len(timelineResponse)) | ||
|
|
||
| // Since the response from DB and API doesn't match as they are relative to the time at which |
illume
reviewed
Jan 10, 2022
illume
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
🎉 Looking good. Thanks for doing this.
I left a little comment about the make target name. Apart from that looks good to me.
I'm not sure if we should be testing the auth related stuff here? But I understand testing auth is out of scope for this PR. Additionally, testing error handling is out of scope of this PR.
In case anyone else is reading, the reason this was done as a http level integration test rather than the usual way with testing handlers... is because the proof-of-concept branch rewrites the backend, so that isn't possible to test the handlers easily. This way the tests can be used on the main branch and then also in the proof of concept branch.
This patch updates the make file to use the docker compose file for tests instead of the shell scripts and docker commands. Signed-off-by: Santhosh Nagaraj S <[email protected]>
|
Thanks @yolossn for such a massive effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
stats_test.go).docker-compose.test.yamlfile.