Revert "kola/tests: Skip tests that change the verity hash when SB is enabled" #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled" This reverts commit b583d18. I misunderstood what these tests do. Booting is supposed to fail after changing the verity hash, but then it is supposed to successfully fall back to the other partition. The tests were failing due one of Red Hat's GRUB patches. We have now fixed this. Signed-off-by: James Le Cuirot <[email protected]>
tormath1
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b583d18. I misunderstood what these tests do. Booting is supposed to fail after changing the verity hash, but then it is supposed to successfully fall back to the other partition. The tests were failing due one of Red Hat's GRUB patches. We have now fixed this.