Azure updates #537
Merged
Azure updates #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user specifies the vnet kola is running from we can disable access to the storage account from outside the running vnet. A related option is --azure-use-private-ips which can be used for accesses to the test vms if kola is in the same vnet or a peered vnet. Signed-off-by: Jeremi Piotrowski <[email protected]>
Waiting for deletion slows down overall test execution and we have automation that regularly cleans up orpaphaned resources. Signed-off-by: Jeremi Piotrowski <[email protected]>
krnowak
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource deletion can take a long time - switch to submitting a deletion request for resource group/VMs but don't poll on the outcome. This doesn't fail 99.9% of the time and we have automation to catch the 0.1%.
Add a parameter (azure-kola-vnet) that allows disabling public access to storage accounts and restricting access to a single vnet.