Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure updates #537

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Azure updates #537

merged 2 commits into from
Jul 4, 2024

Conversation

jepio
Copy link
Member

@jepio jepio commented Jul 3, 2024

Resource deletion can take a long time - switch to submitting a deletion request for resource group/VMs but don't poll on the outcome. This doesn't fail 99.9% of the time and we have automation to catch the 0.1%.

Add a parameter (azure-kola-vnet) that allows disabling public access to storage accounts and restricting access to a single vnet.

jepio added 2 commits July 3, 2024 10:26
If user specifies the vnet kola is running from we can disable access to the
storage account from outside the running vnet. A related option is
--azure-use-private-ips which can be used for accesses to the test vms if kola
is in the same vnet or a peered vnet.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Waiting for deletion slows down overall test execution and we have automation
that regularly cleans up orpaphaned resources.

Signed-off-by: Jeremi Piotrowski <[email protected]>
@jepio jepio requested a review from krnowak July 3, 2024 09:15
@jepio jepio merged commit 5c9351d into flatcar-master Jul 4, 2024
2 checks passed
@jepio jepio deleted the azure-updates branch July 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants