kola: Run qemu and swtpm with the machine folder as working dir #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
jepio
reviewed
Apr 17, 2024
The long UNIX socket path caused problems and the workaround was to shorten the test names but a real solution is to ensure that the path is always short. This can be done by setting the current working directory for the swtpm process to the machine folder which also holds the socket and, in addition, setting the current working directory for the qemu process to the same folder. Then we can use 'tpm/socket' as path which is ensured to be below the limit of 108 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long UNIX socket path caused problems and the workaround was to shorten the test names but a real solution is to ensure that the path is always short. This can be done by setting the current working directory for the swtpm process to the machine folder which also holds the socket and, in addition, setting the current working directory for the qemu process to the same folder. Then we can use 'tpm/socket' as path which is ensured to be below the limit of 108 characters.
How to use
Testing done
Tests passed on GitHub Actions in this test PR