WIP: add ore command to create azure gallery #523
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
force-pushed
the
jepio/gallery
branch
3 times, most recently
from
5ef5765 to
5bdfe19
Compare
jepio
force-pushed
the
jepio/gallery
branch
3 times, most recently
from
44fe874 to
13553d9
Compare
jepio
force-pushed
the
jepio/gallery
branch
3 times, most recently
from
bf40961 to
464f4fd
Compare
We want to indicated support for trusted launch (TPM + secure boot) for testing. Trusted launch is only availabe for Gen2 VMs so we need some conditional template magic to continue working for Gen1 VMs. We also need to indicate image support for NVMe for testing NVMe only instances. For completeness we also mark support for accelerated networking. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
Since all ore commands call WrapPreRun, they overwrite the default implementation that calls StartLogging(). To get plog to work StartLogging() must be called manually. Signed-off-by: Jeremi Piotrowski <[email protected]>
So that commands can set fields like 'Board' later on. Signed-off-by: Jeremi Piotrowski <[email protected]>
This ore command creates a gallery image for use in multiple VM creations, and could be used to speed up multiple kola invocations. The command takes care of uploading the vhd to blob storage and creates resource group and storage account as well. Signed-off-by: Jeremi Piotrowski <[email protected]>
Now that our gallery images are created with trusted launch support, we can enable trusted launch and TPM on the instance. At some point we'll be able to pass custom secure boot keys too. Signed-off-by: Jeremi Piotrowski <[email protected]>
We currently create a storage account for every test cluster. Storage account creation takes 20-30 seconds. This storage account is only used for VM console logs. We can easily reuse a single storage account for all vm console logs, thereby speeding up the whole test execution. Introduce a field called storageAccountRG in struct cluster, so that we can keep track of the correct RG when fetching VM logs. Signed-off-by: Jeremi Piotrowski <[email protected]>
…version Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
So that the deferred flight.Destroy() is called. The only caller terminates the application on failure anyway.
This makes it harder to track down legit failures.
This does not require that the user have RBAC permissions to a storage account to fetch, because it uses SAS keys behind the scenes. The previous approach used a kola created storage account has Shared Key Access disabled for security reasons. Signed-off-by: Jeremi Piotrowski <[email protected]>
This reverts commit 2647b48.
Signed-off-by: Jeremi Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.