Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: update dependencies #472

Merged
merged 1 commit into from
Oct 25, 2023
Merged

docker: update dependencies #472

merged 1 commit into from
Oct 25, 2023

Conversation

tormath1
Copy link
Contributor

With 452 it currently fails to build ARM64 Docker image:

38.77 Preparing to unpack .../google-cloud-cli_452.0.0-0_all.deb ...
38.78 Unpacking google-cloud-cli (452.0.0-0) ...
95.90 Setting up google-cloud-cli (452.0.0-0) ...
96.76 /usr/bin/gcloud: 206: exec: python: not found
96.80 dpkg: error processing package google-cloud-cli (--configure):
96.80  installed google-cloud-cli package post-installation script subprocess returned error exit status 127
96.82 Errors were encountered while processing:
96.82  google-cloud-cli

@tormath1 tormath1 self-assigned this Oct 25, 2023
@t-lo t-lo self-requested a review October 25, 2023 14:50
t-lo
t-lo approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@t-lo t-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the container build now succeeds again. Thank you!

@krnowak @tormath1
Dockerfile: updates
ed52134 
- Switch to golang 1.21.

- Use less cryptic tags for docker images - it's clear now that
  golang:1.21-bookworm is based on debian:bookworm.

- Sort the installed packages alphabetically.

- Move python3 installation to the first `apt-get install` invocation.

- Install python-is-python3 package, seems like gcloud still prefers
  python name instead of python3.

- Refresh the line that installs google-cloud-sdk.
@tormath1 tormath1 marked this pull request as ready for review October 25, 2023 15:28
@tormath1 tormath1 changed the title docker: pin gcloud CLI to 451 docker: update dependencies Oct 25, 2023
@tormath1 tormath1 merged commit 9eef5e9 into flatcar-master Oct 25, 2023
2 checks passed
@tormath1 tormath1 deleted the tormath1/gcloud-cli branch October 25, 2023 15:32
@tormath1
Copy link
Contributor Author

Merging this since the CI has already passed here: https://github.com/flatcar/mantle/actions/runs/6639830669/job/18038995626

@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-lo t-lo t-lo approved these changes

Assignees

@tormath1 tormath1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tormath1 @t-lo @krnowak