Azure identity support #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
azure-identity-support
branch
from
9b7be1a to
6f58c8c
Compare
tormath1
reviewed
Oct 2, 2023
|
I've pushed some fixups for review - will rebase after review is done |
Add support for using a managed identity to authenticate with Azure. This normally requires passing a subscription id through the environment but if the identity only has access to a single subscription we can perform a lookup automatically. Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
Signed-off-by: Jeremi Piotrowski <[email protected]>
This is only used when running kola spawn with marketplace images. This matches what azure-cli does. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
azure-identity-support
branch
from
d72d6fb to
dbdf00c
Compare
tormath1
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using a managed identity for authentication on Azure. This allows running kola/ore without passing credentials, from a VM in Azure. This is similar to existing service-auth support on GCP. The identity needs contributor access at the subscription level.
Test case: