-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for multipart mime in coreos-cloudinit #437
Add tests for multipart mime in coreos-cloudinit #437
Conversation
It seems I don't have access to push to |
Strange, I thought that would work for all PRs… |
Nope. This section: mantle/.github/workflows/docker.yml Lines 44 to 49 in 9cdaa3b
Defines the login credentials. The actor in this case is the PR author and I do not have write access to the mantle packages. |
Is the token the same or also bound to the author? |
Yup. The actor and the token belong to the person triggering the workflow. If triggered via PR, they belong to the author. If triggered via |
070bbb6
to
7a19a2b
Compare
8399dd0
to
fc030de
Compare
Converted to draft for now. This opened a can of worms. Apparently I need to parse the userdata here as well to determine its type and add the testing ssh keys to it so kola can access the vms. Will update it next week. |
f3f2adf
to
414c452
Compare
vendor/github.com/flatcar/ignition/config/shared/errors/errors.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
414c452
to
3d1b594
Compare
Co-authored-by: Kai Lüke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot! I added a few comments.
Co-authored-by: Kai Lüke <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Add tests for the multipart mime support in coreos-cloudinit
The new multipart mime support that is currently being proposed against coreos-cloudinit needs to be tested. This PR adds the needed tests.
These tests will validate that we properly parse the multipart mime user-data and all parts are run correctly.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.